Skip to content

Vignette for use of ppc*pit_ecdf() with new method argument#527

Merged
jgabry merged 28 commits into
stan-dev:masterfrom
florence-bockting:vignette-ppc-ecdf
Jul 22, 2026
Merged

Vignette for use of ppc*pit_ecdf() with new method argument#527
jgabry merged 28 commits into
stan-dev:masterfrom
florence-bockting:vignette-ppc-ecdf

Conversation

@florence-bockting

@florence-bockting florence-bockting commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Fixes #513

Description

This PR introduces a new vignette demonstrating the use of the ppc_pit_ecdf(), ppc_loo_pit_ecdf(), and ppc_pit_ecdf_grouped() functions. Specifically, it covers the new implementation introduced in #428, which added support for dependence-aware uniformity tests.

The vignette focuses on the newly introduced arguments and provides examples of how to interpret the correlation-aware ECDF plots.

TODO

@codecov-commenter

codecov-commenter commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.83%. Comparing base (ad9a76f) to head (9a06cb2).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
+ Coverage   98.79%   98.83%   +0.03%     
==========================================
  Files          35       35              
  Lines        6582     6583       +1     
==========================================
+ Hits         6503     6506       +3     
+ Misses         79       77       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry

jgabry commented Jul 17, 2026

Copy link
Copy Markdown
Member

@florence-bockting is this ready for review now that #428 was merged?

@florence-bockting
florence-bockting marked this pull request as ready for review July 19, 2026 18:16
@florence-bockting

Copy link
Copy Markdown
Contributor Author

@florence-bockting is this ready for review now that #428 was merged?

Thanks for pinging me. I checked the vignette again and made some final adjusts.
Good for review now. Thank you.

@florence-bockting
florence-bockting requested a review from jgabry July 19, 2026 18:18

@jgabry jgabry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @florence-bockting. Just a couple of very minor things.

What was the reason for making this online only? I'm fine with this being an online only vignette, just curious. (It's probably for the best, since with all the images in the other vignettes we're already pushing CRAN's package size limits, if I remember correctly.)

Comment thread vignettes/articles-online-only/loo-pit-correlated-tests.Rmd
Comment thread vignettes/articles-online-only/loo-pit-correlated-tests.Rmd Outdated
Comment thread vignettes/articles-online-only/loo-pit-correlated-tests.Rmd Outdated
Comment thread vignettes/articles-online-only/loo-pit-correlated-tests.Rmd Outdated
@florence-bockting

Copy link
Copy Markdown
Contributor Author

This is great, thanks @florence-bockting. Just a couple of very minor things.

What was the reason for making this online only? I'm fine with this being an online only vignette, just curious. (It's probably for the best, since with all the images in the other vignettes we're already pushing CRAN's package size limits, if I remember correctly.)

Mainly because I use patchwork for plotting and I don't want to introduce it to Suggests.

@jgabry
jgabry merged commit 1d3e364 into stan-dev:master Jul 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vignette for updated ppc_loo_pit_ecdf and ppc_pit_ecdf incl. correlated method

3 participants