You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Left a non-blocking comment and did not approve: this is above the low-risk threshold, Cursor Bugbot did not complete successfully and has an unresolved finding, and human review is needed. Assigned reviewers.
Sent by Cursor Approval Agent: Pull Request Router and Approver
…enapi generation
- Permit null in ValidatorProviderDto.revshare decoding (OpenAPI spec patch,
regenerated schemas, and domain regression tests).
- Target production API doc endpoints (api.stakek.it, api.yield.xyz, and
borrow.yield.xyz) for OpenAPI generation.
- Strip _v1 operation ID suffixes emitted by NestJS URI versioning so client
methods and DTOs retain stable names.
- Close unannotated OpenAPI object schemas in prepareSpecContents so Effect
rc.115 generates Schema.Struct preserving .fields access.
- Support "supplyAndBorrow" action and "BUNDLE" transaction types in SKBorrowTxMeta.
- Add blueBundleOriginationFeeBps to borrow test mock fixtures.
The reason will be displayed to describe this comment to others. Learn more.
Risk: medium. Left a non-blocking comment and did not approve: regenerated API clients/schemas and OpenAPI generation changes exceed the low-risk threshold, so human review is needed. Reviewers were already assigned, so none were added.
Sent by Cursor Approval Agent: Pull Request Router and Approver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Summary
nullforValidatorProviderDto.revsharein OpenAPI decoding, regenerate API schemas and clients, and add regression coverage.LegacyApiOpenAPI document URL at staging to avoid the production ALB 404._v1suffixes from generated operation names so client methods and DTOs keep stable names.prepareSpecContentsso Effect rc.115 generatesSchema.Structvalues with.fields.Why
Validator and yield-provider responses can return
revshare: null. The generated decoder previously rejected those responses.Supersedes #570.