Conversation
ajag408
added this pull request to stack #36
September 12, 2026 00:29
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
ajag408
requested review from
Philippoes,
aditya172926,
auralshin,
dnehl,
jdomingos,
nicolasbrugneaux and
raiseerco
September 12, 2026 00:31
Ishita-02
previously approved these changes
Sep 17, 2026
ajag408
force-pushed
the
eng-3209-oav-context-docs
branch
from
September 17, 2026 19:39
6c6d7cf to
d343a44
Compare
There was a problem hiding this comment.
Risk: medium. Left a non-blocking comment; Bugbot and Security Agent completed without findings that need human review, but the schema change on allocator vault address validation is above the low-risk approval threshold. Reviewers were not assigned because two or more are already requested.
Sent by Cursor Approval Agent: Pull Request Router and Approver
Philippoes
approved these changes
Sep 17, 2026
jdomingos
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
context(additive; bakedvault-registry.jsonis not the freshness gate) and thatcontextis trusted control-plane data, never from the user or the tx.allocatorVaultInputTokenAddressis required for injected-OAV APPROVAL.pattern: '^0x[0-9a-fA-F]{40}$'onallocatorVaultAddressandallocatorVaultInputTokenAddress; handler tests accept valid hex and rejectnot-an-addresswithSCHEMA_VALIDATION_ERROR.QA Proof
What Needs to Be QA'd in Staging
validatewith validcontext.feeConfiguration[].allocatorVaultAddress+allocatorVaultInputTokenAddressstill succeeds (schema layer)allocatorVaultAddress: "not-an-address"returnsSCHEMA_VALIDATION_ERROR(does not run the yield validator)mainvault-registry.jsonas the OAV allowlistQA Team Notification
Note
Medium Risk
Tightening
contextaddress patterns can reject previously schema-valid garbage strings; incorrect caller handling of trustedcontextstill expands the OAV whitelist and bypasses Shield.Overview
Documents runtime OAV injection via
context.feeConfiguration: callers should pass project OAVs on everyvalidatecall (additive to the embeddedvault-registry.jsonsnapshot), withallocatorVaultInputTokenAddressrequired for injected-OAV APPROVAL only. The README clarifies that the baked registry is not the freshness gate for allowed OAVs and thatcontextmust be trusted server-side control-plane data, never user- or tx-supplied.JSON schema now requires
0x+ 40 hex digits forallocatorVaultAddressandallocatorVaultInputTokenAddress; invalid strings fail at the schema layer withSCHEMA_VALIDATION_ERRORbefore yield validation runs.Handler tests hoist shared Lido fixtures and add coverage for valid/mixed-case hex, optional input token, and rejected non-address values.
Reviewed by Cursor Bugbot for commit d343a44. Configure here.