fix: extract replicationcontroller selectors - #1189
Open
GeneCodeSavvy wants to merge 1 commit into
Open
Conversation
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1189 +/- ##
===========================================
- Coverage 62.36% 30.76% -31.60%
===========================================
Files 197 239 +42
Lines 4854 6536 +1682
===========================================
- Hits 3027 2011 -1016
- Misses 1439 4349 +2910
+ Partials 388 176 -212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhybrillou
approved these changes
Jun 29, 2026
rhybrillou
reviewed
Jul 3, 2026
rhybrillou
left a comment
rhybrillou
left a comment
Contributor
There was a problem hiding this comment.
The change looks good overall.
Could you please use testify packages (assert or require) for the test validation instead of manual checks and calls to t.Fatal ?
Comment on lines
+6
to
+7
|
|
||
| coreV1 "k8s.io/api/core/v1" |
Contributor
There was a problem hiding this comment.
Suggested change
| coreV1 "k8s.io/api/core/v1" | |
| "github.com/stretchr/testify/require" | |
| coreV1 "k8s.io/api/core/v1" |
Comment on lines
+21
to
+23
| if !found { | ||
| t.Fatal("expected selector to be found") | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if !found { | |
| t.Fatal("expected selector to be found") | |
| } | |
| require.True(t, found, "expected selector to be found") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1188