ROX-32487 Add RHCOS 10 integration tests for OCP 4.22+

[robbycochran]

Summary

• Updated fetch_ocp_rhcos_bootimage.sh to support an optional rhel-variant argument (e.g., rhel-9, rhel-10). OCP 4.22+ splits RHCOS boot images into coreos-rhel-9.json and coreos-rhel-10.json instead of the single rhcos.json used by earlier releases. The script remains backward compatible for older OCP versions.
• Added RHCOS 10 and OCP 4.20 images to the integration test matrix, covering all OCP releases with extended support:

rhcos (x86_64)

RHEL	OCP
10.2	4.22
9.6	4.22
9.6	4.20
9.4	4.18
9.4	4.16
9.2	4.14
8.6	4.12

rhcos-arm64

RHEL	OCP
10.2	4.22
9.6	4.22
9.6	4.20
9.4	4.18
9.4	4.16

Test plan

• Verified fetch_ocp_rhcos_bootimage.sh resolves all images correctly with both old and new URL formats
• CI integration tests pass on RHCOS VMs (including new RHEL 10 images)
  All rhcos jobs on CI pass for x86
  All rhcos jobs on CI pass for fcarm64

[coderabbitai]

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately describes the main objective of the PR: adding RHCOS 10 integration tests for OCP 4.22+, which aligns with the changes made to support RHEL 10 images in the configuration and script updates.
Description check	✅ Passed	The PR description provides a clear summary, comprehensive test plan with verification results, and detailed tables of tested image configurations.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rc-add-rhcos10

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.34%. Comparing base (8b42e7a) to head (6feb165).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3152   +/-   ##
=======================================
  Coverage   27.34%   27.34%           
=======================================
  Files          95       95           
  Lines        5420     5420           
  Branches     2545     2545           
=======================================
  Hits         1482     1482           
  Misses       3211     3211           
  Partials      727      727           

Flag	Coverage Δ
collector-unit-tests	27.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ansible/scripts/fetch_ocp_rhcos_bootimage.sh`:
- Around line 17-21: The script constructs URL based on RHEL_VARIANT into the
variable URL but does not validate the HTTP response or JSON before extracting
the image name; update the fetch/parse sequence that consumes URL to (1) use a
strict HTTP fetch (curl/wget with fail and show-error flags) and check the HTTP
status, (2) validate the response is valid JSON (e.g., pipe to jq --exit-status)
and that the expected image field/key exists and is non-empty, and (3) if any
check fails, print a clear error referencing URL and exit non‑zero so the script
fails fast instead of producing an empty image value; locate the fetch/parse
code that reads URL and the variable name holding the image to apply these
checks.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 11d7f97a-5e1c-4bc3-a316-40e76358b373

📥 Commits

Reviewing files that changed from the base of the PR and between c8c0181 and 8faad73.

📒 Files selected for processing (2)

• ansible/group_vars/all.yml
• ansible/scripts/fetch_ocp_rhcos_bootimage.sh

[Molter73]

Looks fine, just wondering why we are removing 4.16 since it still has extended support. Also, should we add 4.20 to the test matrix?

[robbycochran]

Looks fine, just wondering why we are removing 4.16 since it still has extended support. Also, should we add 4.20 to the test matrix?

Added 4.16 back, with comment for now on when support ends.