Add default resource limits for MCPRemoteProxy - #5998
Open
clxstart wants to merge 2 commits into
Open
Conversation
Apply proxy-runner defaults when MCPRemoteProxy omits resource requests/limits, merge user overrides on top of those defaults, and keep deployment drift detection aligned with the same effective resource calculation. Closes stacklok#3131
clxstart
requested review from
ChrisJBurns,
JAORMX,
blkt,
jerm-dro,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
July 26, 2026 04:48
…-mcpremoteproxy-1785037451518
github-actions
Bot
added
size/S
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5998 +/- ##
==========================================
+ Coverage 72.16% 72.19% +0.03%
==========================================
Files 721 721
Lines 75069 75100 +31
==========================================
+ Hits 54174 54222 +48
+ Misses 17033 17018 -15
+ Partials 3862 3860 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
@clxstart Thanks for the PR! You'll need to resolve the lint failures first before we can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCPRemoteProxyomitsspec.resourcesContext
Fixes #3131
Without defaults, remote proxy containers can run unbounded when
spec.resourcesis empty. This mirrors the existing VirtualMCPServer/MCPServer defaulting intent and keeps create/update paths consistent.Default values
50m/200m64Mi/256MiTest plan
go test ./cmd/thv-operator/pkg/controllerutil -run 'TestBuildDefaultProxyRunnerResourceRequirements|TestMergeResourceRequirements|TestEnsureRequiredEnvVars'go test ./cmd/thv-operator/controllers -run 'TestDeploymentForMCPRemoteProxy|TestBuildResourceRequirements|TestResourceRequirementsForRemoteProxy|TestMCPRemoteProxyDeploymentNeedsUpdate_Resources'spec.resourcesgets defaults