Address review findings from v0.1 skills OpenAPI PR#4802
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4802 +/- ##
==========================================
+ Coverage 68.96% 69.00% +0.03%
==========================================
Files 517 517
Lines 54829 54833 +4
==========================================
+ Hits 37815 37837 +22
+ Misses 14098 14076 -22
- Partials 2916 2920 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
rdimitrov
previously approved these changes
Apr 14, 2026
Clamp out-of-range limit values to the maximum (200) instead of silently falling back to the default (50). Cap page to prevent integer overflow in the (page-1)*limit calculation that could panic on slice bounds. Remove the dead @description annotation on skillsV01Metadata — swag overrides it with the field-level comment from skillsV01Response. Add @description and field-level doc comments to registryErrorResponse so the generated schema includes descriptions consistent with the other types promoted by the OpenAPI annotations. Regenerate docs/server/ to reflect all changes. Ref: #4800 Made-with: Cursor
samuv
force-pushed
the
fn-open-api-registry
branch
from
567da35 to
4753588
Compare
github-actions
bot
added
size/XS
ChrisJBurns
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the three review comments from #4800:
limitvalues to the max (200) instead of silently falling back to the default (50) —?limit=201now returns 200 results@Descriptionannotation onskillsV01Metadata(swag overrides it with the field comment fromskillsV01Response)@Descriptionand field comments toregistryErrorResponseso the generated schema includes a descriptionRef: #4800
Type of change
Test plan
task test)task lint-fix)task docsChanges
pkg/api/v1/registry_v01_skills.go@Descriptionpkg/api/v1/registry.go@Descriptionand field comments toregistryErrorResponsepkg/api/v1/registry_v01_skills_test.godocs/server/*Does this introduce a user-facing change?
Yes —
?limit=Nwhere N > 200 now returns 200 items (clamped) instead of silently returning 50.