Conversation
samuv
added this pull request to stack #1701
September 18, 2026 09:51
Omit decoder causes at the successful HTTP and SSE payload boundary while retaining safe metadata and preserving body-read, server, authentication, transport, and cancellation causes. Relates to #1694 Co-authored-by: Codex <codex@openai.com> Signed-off-by: Samuele Verzi <samu@stacklok.com>
samuv
force-pushed
the
impl/sdk-malformed-success-causes
branch
from
September 18, 2026 09:57
ae1e0fc to
628f3c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProtocolErrorvalues.Development stage
Contract linkage
docs/adr/0348-typescript-sdk-malformed-success-decoding.mdgh stacklayer without waiting for the Plan / Interface PR to merge; neither PR is authorized to merge heredocs/acceptance/sdk-malformed-success-decoding.mdb6e05820685a85bf3cf027ed42da4e269060e6edunder the recorded stacking waiver; it is not yet merged authorityInterface conformance
Matches the exact committed plan contract. There are no protobuf, Go API, tool, CLI/config, event, persistence, or public TypeScript signature changes.
Issue relationship
Closes #1694
Type of change
Test plan
Baseline checks
task lint)task test) — host Xcode/macOS 27 linker rejects its ownarm64e.x1-*SDK architectures across CGO-linked test binaries; one unrelatedTestCarryoverHandoffalso timed out during the degraded run. CI must supply this proof.CGO_ENABLED=0 go run ./cmd/mecademo)CGO_ENABLED=0 task docs)task site:build)/panel-reviewAdditional SDK gates:
task sdk:lint sdk:typecheck sdk:test sdk:build sdk:api:check sdk:docs:checkChanges
sdk/typescript/src/http.tssdk/typescript/test/http-decoding-errors.test.tssdk/typescript/src/errors.ts, generated API referenceUser-facing change
Applications receive the same
ProtocolErrorclass, code, message, transport, and status for malformed successful HTTP/SSE payloads, plus a response request ID when present. These errors no longer expose the decoder exception throughcause.Special notes for reviewers
Unary body acquisition is intentionally separate from
JSON.parse(): aresponse.text()failure retains the existing causedProtocolError. SSEreader.read()failures remain outside decoder catches. The final CI test result is the only pending acceptance-plan gate; this PR does not claim the plan is landed.