Fix remaining CRD field issues across K8s and vMCP docs#723
Merged
ChrisJBurns merged 3 commits intomainfrom Apr 15, 2026
Merged
Fix remaining CRD field issues across K8s and vMCP docs#723ChrisJBurns merged 3 commits intomainfrom
ChrisJBurns merged 3 commits intomainfrom
Conversation
- mcp-server-entry: Fix remoteURL -> remoteUrl (5 occurrences) - configuration: Fix remoteURL -> remoteUrl (2 occurrences) - backend-discovery: Fix incomingAuth.oidc -> oidcConfigRef - failure-handling: Fix incomingAuth.oidc -> oidcConfigRef - optimizer: Fix modelCache.storageSize -> modelCache.size Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ToolHive K8s Operator and vMCP documentation YAML examples to match current CRD field names, resolving remaining validation failures discovered via dry-run testing.
Changes:
- Replace
remoteURLwithremoteUrlin MCPRemoteProxy and MCPServerEntry examples. - Replace
incomingAuth.oidcwithincomingAuth.oidcConfigRefin VirtualMCPServer examples. - Replace
modelCache.storageSizewithmodelCache.sizein the EmbeddingServer example.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/toolhive/guides-vmcp/optimizer.mdx | Updates EmbeddingServer model cache field name to the current CRD schema. |
| docs/toolhive/guides-vmcp/failure-handling.mdx | Updates VirtualMCPServer incoming OIDC auth example to use oidcConfigRef. |
| docs/toolhive/guides-vmcp/configuration.mdx | Fixes remoteUrl casing in MCPRemoteProxy and MCPServerEntry examples. |
| docs/toolhive/guides-vmcp/backend-discovery.mdx | Updates discovered-mode VirtualMCPServer auth example to use oidcConfigRef. |
| docs/toolhive/guides-k8s/mcp-server-entry.mdx | Fixes remoteUrl casing across MCPServerEntry examples. |
Update remoteURL references in prose text to match the remoteUrl YAML fixes, and replace deprecated inline oidcConfig with oidcConfigRef in the optimizer complete example. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The complete example referenced engineering-oidc via oidcConfigRef but never defined the MCPOIDCConfig resource, making the example incomplete for copy-paste usage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
danbarr
approved these changes
Apr 15, 2026
yrobla
pushed a commit
that referenced
this pull request
Apr 16, 2026
* Fix remaining CRD field issues across K8s and vMCP docs - mcp-server-entry: Fix remoteURL -> remoteUrl (5 occurrences) - configuration: Fix remoteURL -> remoteUrl (2 occurrences) - backend-discovery: Fix incomingAuth.oidc -> oidcConfigRef - failure-handling: Fix incomingAuth.oidc -> oidcConfigRef - optimizer: Fix modelCache.storageSize -> modelCache.size Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix stale field names in prose and deprecated oidcConfig usage Update remoteURL references in prose text to match the remoteUrl YAML fixes, and replace deprecated inline oidcConfig with oidcConfigRef in the optimizer complete example. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add missing MCPOIDCConfig to backend discovery complete example The complete example referenced engineering-oidc via oidcConfigRef but never defined the MCPOIDCConfig resource, making the example incomplete for copy-paste usage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 10 remaining CRD validation failures found during full dry-run
testing of all 26 K8s Operator and vMCP docs (108 YAML blocks total).
These are issues that were not covered by PRs #715, #720, or #722.
Fixes:
remoteURL->remoteUrlon MCPServerEntryresources (5 occurrences)
remoteURL->remoteUrlon MCPRemoteProxy andMCPServerEntry resources (2 occurrences)
incomingAuth.oidc->oidcConfigRefonVirtualMCPServer (unknown field
oidc)incomingAuth.oidc->oidcConfigRefonVirtualMCPServer (unknown field
oidc)modelCache.storageSize->modelCache.sizeonEmbeddingServer (unknown field
storageSize)Not addressed (CRD bug, not doc issue):
One additional failure in vmcp/telemetry-and-metrics.mdx is caused by a CEL
validation rule on the VirtualMCPServer CRD that checks
self.config.telemetryeven whenconfigis not present on the resource.The doc correctly uses
telemetryConfigRefwithoutconfig.telemetry, butthe CEL rule
!(has(self.config.telemetry) && has(self.telemetryConfigRef))errors because
self.configdoesn't exist. This should be fixed in the CRD,not the docs.
Test plan
🤖 Generated with Claude Code