Conversation
STACKITTPR-550 Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Fyusel
marked this pull request as draft
September 15, 2026 06:53
marceljk
reviewed
Sep 15, 2026
Comment on lines
+109
to
+118
| // StringPointerValueNullIfEmpty converts a string pointer to types.String, treating an empty | ||
| // string as null. Some APIs return "" instead of omitting unset optional fields, which would | ||
| // otherwise mismatch a null config for Optional, non-Computed attributes. | ||
| func StringPointerValueNullIfEmpty(s *string) types.String { | ||
| if s == nil || *s == "" { | ||
| return types.StringNull() | ||
| } | ||
| return types.StringValue(*s) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
types.StringPointerValue() can be used instead. It does the same thing and comes directly from the framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACKITTPR-550
Note: There will be changes regarding API. Added as draft in order that colleagues can continue the work if needed.
Description
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)