Onboarding Intake(1/3): Intake Runner by devanshcache · Pull Request #1086 · stackitcloud/terraform-provider-stackit

devanshcache · 2025-12-08T08:08:19Z

Description

This PR onboards the new STACKIT Intake (ticket) service into the Terraform provider.

Intake is composed of three components:

Intake Runners: dedicated, isolated runtime data ingestion environment
Intake: a specific data stream or topic within an Intake Runner
Intake Users: provides secure access credentials for your applications to connect to your Intake

This PR contains the Intake Runners part only to make a quicker and less overwhelming review.

Checklist

Issue was linked above
Code format was applied: make fmt
Examples were added / adjusted (see examples/ directory)
Docs are up-to-date: make generate-docs (will be checked by CI)
Unit tests got implemented or updated
Acceptance tests got implemented or updated (see e.g. here)
Unit tests are passing: make test (will be checked by CI)
No linter issues: make lint (will be checked by CI)

stackit/internal/services/intake/runner/resource.go

stackit/internal/services/intake/runner/resource_acc_test.go

docs/resources/intake_runner.md

stackit/internal/services/intake/runner/data_source.go

stackit/internal/services/intake/runner/resource.go

stackit/provider.go

stackit/internal/services/intake/runner/data_source.go

stackit/internal/services/intake/runner/resource_acc_test.go

rubenhoenle · 2026-01-26T09:45:30Z

@yago-123 could you please resolve the comments you adressed already? I will only start with another review as soon as all open comments are resolved.

rubenhoenle · 2026-01-26T09:51:21Z

And please check that failing CI pipeline. Maybe run a make lint and a make test before your next update of this PR 😅

yago-123 · 2026-01-26T10:02:51Z

@yago-123 could you please resolve the comments you adressed already? I will only start with another review as soon as all open comments are resolved.

Yes! notice this is still in progress though

stackit/internal/services/intake/runner/resource.go

stackit/internal/services/intake/testdata/resource-min.tf

stackit/internal/services/intake/testdata/resource-max.tf

stackit/internal/services/intake/utils/utils.go

stackit/internal/services/intake/resource_acc_test.go

stackit/internal/services/intake/runner/data_source.go

stackit/internal/services/intake/runner/resource.go

…AndLogStateFields

github-actions · 2026-04-09T04:05:21Z

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

rubenhoenle · 2026-04-10T09:55:38Z

stackit/internal/services/intake/testdata/resource-max.tf

+  project_id            = var.project_id
+  name                  = var.name
+  region                = var.region
+  description           = "An example runner for Intake"


Please use a variable here instead of hardcoding

rubenhoenle · 2026-04-10T09:58:28Z

stackit/internal/services/intake/resource_acc_test.go

+					resource.TestCheckResourceAttr(intakeRunnerResource, "max_message_size_kib", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMin["max_message_size_kib"])),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "max_messages_per_hour", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMin["max_messages_per_hour"])),
+					resource.TestCheckResourceAttrSet(intakeRunnerResource, "id"),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "region", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMax["region"])),


Please verify here that the description field is unset

same for labels

rubenhoenle · 2026-04-10T09:59:01Z

stackit/internal/services/intake/resource_acc_test.go

+					resource.TestCheckResourceAttrPair(intakeRunnerResource, "runner_id", "data.stackit_intake_runner.example", "runner_id"),
+					resource.TestCheckResourceAttrPair(intakeRunnerResource, "name", "data.stackit_intake_runner.example", "name"),
+					resource.TestCheckResourceAttrPair(intakeRunnerResource, "region", "data.stackit_intake_runner.example", "region"),
+					resource.TestCheckResourceAttrPair(intakeRunnerResource, "max_messages_per_hour", "data.stackit_intake_runner.example", "max_messages_per_hour"),


rubenhoenle · 2026-04-10T09:59:09Z

stackit/internal/services/intake/resource_acc_test.go

+					resource.TestCheckResourceAttr(intakeRunnerResource, "max_messages_per_hour", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMin["max_messages_per_hour"])),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "region", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMax["region"])),
+					resource.TestCheckResourceAttrSet(intakeRunnerResource, "runner_id"),
+					resource.TestCheckResourceAttrSet(intakeRunnerResource, "id"),


rubenhoenle · 2026-04-10T10:00:24Z

stackit/internal/services/intake/resource_acc_test.go

+					resource.TestCheckResourceAttr(intakeRunnerResource, "max_message_size_kib", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMin["max_message_size_kib"])),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "max_messages_per_hour", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMin["max_messages_per_hour"])),
+					resource.TestCheckResourceAttrSet(intakeRunnerResource, "id"),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "region", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMax["region"])),


Suggested change

resource.TestCheckResourceAttr(intakeRunnerResource, "region", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMax["region"])),

resource.TestCheckResourceAttr(intakeRunnerResource, "region", testutil.Region),

Don't use the max values in the min test please :)

rubenhoenle · 2026-04-10T10:00:47Z

stackit/internal/services/intake/resource_acc_test.go

+					resource.TestCheckResourceAttr(intakeRunnerResource, "name", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMinUpdated()["name"])),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "max_message_size_kib", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMin["max_message_size_kib"])),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "max_messages_per_hour", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMin["max_messages_per_hour"])),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "region", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMax["region"])),


Suggested change

resource.TestCheckResourceAttr(intakeRunnerResource, "region", testutil.ConvertConfigVariable(testIntakeRunnerConfigVarsMax["region"])),

resource.TestCheckResourceAttr(intakeRunnerResource, "region", testutil.Region),

rubenhoenle · 2026-04-10T10:02:40Z

stackit/internal/services/intake/runner/resource.go

+				Description: descriptions["region"],
+				PlanModifiers: []planmodifier.String{
+					stringplanmodifier.RequiresReplace(),
+				},


What about the uri and create_time fields? Could be included as computed fields. Same for the datasource.

Don't forget to include them in your Acc tests.

You can also do it in a follow-up PR if you want, then we can merge this one first.

rubenhoenle · 2026-04-10T10:06:37Z

stackit/internal/services/intake/resource_acc_test.go

@@ -0,0 +1,268 @@
+package intake_test


please name that file intake_acc_test.go to stick with our conventions

rubenhoenle · 2026-04-10T10:07:13Z

Also please rebase your branch, you have some conflicts here

devanshcache requested a review from a team as a code owner December 8, 2025 08:08

devanshcache changed the title ~~onboarding(1/3): Intake Runner~~ Onboarding Intake(1/3): Intake Runner Dec 8, 2025

rubenhoenle reviewed Dec 12, 2025

View reviewed changes

stackit/internal/services/intake/runner/resource.go Show resolved Hide resolved

marceljk added the ignore-stale label Dec 19, 2025

rubenhoenle removed the ignore-stale label Jan 19, 2026