feat: Support setting federated token as env#6275
Draft
JorTurFer wants to merge 1 commit intostackitcloud:mainfrom
Draft
feat: Support setting federated token as env#6275JorTurFer wants to merge 1 commit intostackitcloud:mainfrom
JorTurFer wants to merge 1 commit intostackitcloud:mainfrom
Conversation
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR supports setting the federated token directly as env var. This is not really useful for long term workloads but it's quite interesting for CI processes (I need this to support Gitlab in terraform) and I think that adding the default behaviour to the SDK is better than adding the logic in multiple places.
Thanks to this change, if there is an env var
STACKIT_FEDERATED_TOKENin the system, it will be used as "raw"token, if not, it'll look for
STACKIT_FEDERATED_TOKEN_FILEas before. Any override done by the SDK caller is respected, this is just a change in default behaviour when missing extra configsChecklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)