Add application load balancer controller with ingress support#54
Conversation
|
Our project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
|
/lifecycle frozen |
|
@dergeberl: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f53e478 to
d1f39df
Compare
69f9b8e to
7c74c4c
Compare
|
/lgtm lets wait for a proper release |
|
@dergeberl: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override pull-gardener-extension-provider-stackit-integration-tests |
|
@breuerfelix: Overrode contexts on behalf of breuerfelix: pull-gardener-extension-provider-stackit-integration-tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
LGTM label has been added. DetailsGit tree hash: c9db5a85ed95f9da2b01d86a5969a46a80a4bf2b |
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breuerfelix, nschad The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override pull-gardener-extension-provider-stackit-integration-tests |
|
@nschad: Overrode contexts on behalf of nschad: pull-gardener-extension-provider-stackit-integration-tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
This PR adds the application load balancer controller (stackitcloud/application-load-balancer-controller) to the gardener-extension-provider-stackit.
There was already some tests merged in this repo which did not work. So it should be safe to change that parts.
This PR removes the existing config field
deployALBIngressController, removes the old feature gate, name things consistently, add a validation with config option if alb controller is allowedThis PR makes use of the validation of the shoot via the admission webhook. Therefore this PR is based on #203 and has to be merged after this.
/hold
The application load balancer controller is currently still under development and this PR uses a feature build (see PR stackitcloud/application-load-balancer-controller#3). We only should merge this after we adopted the version in the imagevector to a released version.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: