Skip to content

Add application load balancer controller with ingress support#54

Merged
ske-prow[bot] merged 5 commits into
mainfrom
alb
Jul 17, 2026
Merged

Add application load balancer controller with ingress support#54
ske-prow[bot] merged 5 commits into
mainfrom
alb

Conversation

@dergeberl

@dergeberl dergeberl commented Mar 17, 2026

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

This PR adds the application load balancer controller (stackitcloud/application-load-balancer-controller) to the gardener-extension-provider-stackit.

There was already some tests merged in this repo which did not work. So it should be safe to change that parts.

This PR removes the existing config field deployALBIngressController, removes the old feature gate, name things consistently, add a validation with config option if alb controller is allowed

This PR makes use of the validation of the shoot via the admission webhook. Therefore this PR is based on #203 and has to be merged after this.

/hold
The application load balancer controller is currently still under development and this PR uses a feature build (see PR stackitcloud/application-load-balancer-controller#3). We only should merge this after we adopted the version in the imagevector to a released version.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Enhancement, improvement, extension size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2026
@ske-prow ske-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2026
@stackit-ske

Copy link
Copy Markdown

Our project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@ske-prow ske-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2026
@dergeberl

Copy link
Copy Markdown
Member Author

/lifecycle frozen

@ske-prow

ske-prow Bot commented Apr 14, 2026

Copy link
Copy Markdown

@dergeberl: The lifecycle/frozen label cannot be applied to Pull Requests.

Details

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dergeberl dergeberl added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 14, 2026
@ske-prow ske-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2026
@dergeberl
dergeberl force-pushed the alb branch 5 times, most recently from f53e478 to d1f39df Compare July 8, 2026 08:51
@ske-prow ske-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2026
@dergeberl
dergeberl force-pushed the alb branch 8 times, most recently from 69f9b8e to 7c74c4c Compare July 8, 2026 13:06
Comment thread pkg/admission/validator/shoot.go Outdated
Comment thread pkg/apis/stackit/validation/controlplane_test.go
Comment thread pkg/controller/controlplane/valuesprovider.go
Comment thread pkg/controller/controlplane/valuesprovider.go
Comment thread imagevector/images.yaml Outdated
@breuerfelix

Copy link
Copy Markdown
Member

/lgtm lets wait for a proper release

@ske-prow ske-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2026
@ske-prow ske-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2026
@ske-prow

ske-prow Bot commented Jul 16, 2026

Copy link
Copy Markdown

@dergeberl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-extension-provider-stackit-infra-integration-tests 1c5e7ac link true /test pull-gardener-extension-provider-stackit-infra-integration-tests

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@breuerfelix

Copy link
Copy Markdown
Member

/override pull-gardener-extension-provider-stackit-integration-tests
only the prefix override is failing

@ske-prow

ske-prow Bot commented Jul 16, 2026

Copy link
Copy Markdown

@breuerfelix: Overrode contexts on behalf of breuerfelix: pull-gardener-extension-provider-stackit-integration-tests

Details

In response to this:

/override pull-gardener-extension-provider-stackit-integration-tests
only the prefix override is failing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow ske-prow Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 16, 2026
@ske-prow

ske-prow Bot commented Jul 16, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: c9db5a85ed95f9da2b01d86a5969a46a80a4bf2b

@breuerfelix

Copy link
Copy Markdown
Member

/hold cancel

@ske-prow ske-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2026
@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breuerfelix, nschad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nschad

nschad commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/override pull-gardener-extension-provider-stackit-integration-tests

@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

@nschad: Overrode contexts on behalf of nschad: pull-gardener-extension-provider-stackit-integration-tests

Details

In response to this:

/override pull-gardener-extension-provider-stackit-integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow
ske-prow Bot merged commit a4ef6d0 into main Jul 17, 2026
4 checks passed
@ske-prow
ske-prow Bot deleted the alb branch July 17, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants