Skip to content

remove region env var and retrieve from config instead#183

Open
aniruddha2000 wants to merge 1 commit into
mainfrom
cleanup-stackit-client-2
Open

remove region env var and retrieve from config instead#183
aniruddha2000 wants to merge 1 commit into
mainfrom
cleanup-stackit-client-2

Conversation

@aniruddha2000

@aniruddha2000 aniruddha2000 commented Jun 19, 2026

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

This PR removed the region from the deployment environment variable because CSI retrieves it from config instead.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

should be meged with stackitcloud/cloud-provider-stackit#1244 @breuerfelix

Breaking changes:

@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2026
@nschad

nschad commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Please add a description @aniruddha2000

@nschad

nschad commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

/hold requires release of new cloud-provider-stackit

@ske-prow ske-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2026
@stackit-ske

Copy link
Copy Markdown

Our project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@ske-prow ske-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2026
@nschad

nschad commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

/remove-lifecycle stale

@ske-prow ske-prow Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2026
@nschad

nschad commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/unhold
/lgtm
/approve

@ske-prow ske-prow Bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 17, 2026
@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 12fb8aa49e0d2e71c0a2d65ecdebd37967db4338

@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nschad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2026
@nschad

nschad commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/override pull-gardener-extension-provider-stackit-integration-tests

@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

@nschad: Overrode contexts on behalf of nschad: pull-gardener-extension-provider-stackit-integration-tests

Details

In response to this:

/override pull-gardener-extension-provider-stackit-integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants