Skip to content

add metrics endpoint for csi#178

Merged
ske-prow[bot] merged 5 commits into
mainfrom
add-generic-metrics
Jul 17, 2026
Merged

add metrics endpoint for csi#178
ske-prow[bot] merged 5 commits into
mainfrom
add-generic-metrics

Conversation

@aniruddha2000

@aniruddha2000 aniruddha2000 commented Jun 17, 2026

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement
What this PR does / why we need it:

This PR exposes endpoint and port for csi metrics using external APIs

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2026
nschad
nschad requested changes Jun 18, 2026
View reviewed changes

@nschad nschad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add the port to the Service

Comment thread ...plane/charts/stackit-blockstorage-csi-driver/templates/deployment-csi-driver-controller.yaml Outdated
@ske-prow ske-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2026
@aniruddha2000 aniruddha2000 mentioned this pull request Jun 24, 2026
Merged
nschad
nschad requested changes Jul 1, 2026
View reviewed changes
Comment thread charts/internal/seed-controlplane/charts/stackit-blockstorage-csi-driver/templates/service.yaml Outdated
Comment thread charts/internal/seed-controlplane/charts/stackit-blockstorage-csi-driver/templates/service.yaml
@nschad
nschad force-pushed the add-generic-metrics branch from 9058711 to 27abf66 Compare July 1, 2026 09:45
@nschad

nschad commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

/hold requires CSI version bump to support setting --metrics-address

/lgtm

@ske-prow ske-prow Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 1, 2026
@ske-prow

ske-prow Bot commented Jul 1, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 3601d9cc4e9c8bffbe01b49c6487e6a1d3a5c156

@ske-prow ske-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2026
@aniruddha2000
add metrics endpoint for csi
e24b9ef
@aniruddha2000
add metrics address in csi driver deployment arg
9197917 
# Conflicts:
#	charts/internal/seed-controlplane/charts/stackit-blockstorage-csi-driver/templates/deployment-csi-driver-controller.yaml
@aniruddha2000
add variable in metric port
398d3ba
@aniruddha2000
expose metrics port via service
1c9143e
@aniruddha2000
add annotation to service
b44af7a
@ske-prow ske-prow Bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 14, 2026
@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nschad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2026
@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: adc36ab44dbc51df0f9e6ab75dbc0b30b6c317d6

@nschad

nschad commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/unhold

@ske-prow ske-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2026
@nschad

nschad commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/retest

@nschad

nschad commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/override pull-gardener-extension-provider-stackit-integration-tests

@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

@nschad: Overrode contexts on behalf of nschad: pull-gardener-extension-provider-stackit-integration-tests

Details

In response to this:

/override pull-gardener-extension-provider-stackit-integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow
ske-prow Bot merged commit ecb043d into main Jul 17, 2026
4 checks passed
@ske-prow
ske-prow Bot deleted the add-generic-metrics branch July 17, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschad nschad nschad approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aniruddha2000 @nschad