Skip to content

adjust CSI for iaas v1.13.0#1376

Merged
ske-prow[bot] merged 3 commits into
mainfrom
drop-unnecessary-api-call
Jul 17, 2026
Merged

adjust CSI for iaas v1.13.0#1376
ske-prow[bot] merged 3 commits into
mainfrom
drop-unnecessary-api-call

Conversation

@nschad

@nschad nschad commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

  • remove api call for retrieving the AZ of the a Snapshot, since that information is now directly available from retrieving the Snapshot. GetVolume() call removed
  • add missing volume error states
  • Unrelated to the Dependency Bump: Check volume status before trying to attach to avoid unnecessary API calls

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2026
nschad added 2 commits July 16, 2026 14:07
@nschad
reduce API calls by retrieving the AZ from the snapshot directly
20ea3a3 
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad
add missing volume error codes to volumeErrorStates
8c7bae7 
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad
nschad force-pushed the drop-unnecessary-api-call branch from 1eb6aec to 8c7bae7 Compare July 16, 2026 12:08
@ske-prow ske-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2026
dergeberl
dergeberl reviewed Jul 16, 2026
View reviewed changes
Comment thread pkg/stackit/client/iaas.go
@nschad

nschad commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

/hold

checking with IaaS if AVAILABLE is the only "good" state

@ske-prow ske-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2026
@nschad
nschad force-pushed the drop-unnecessary-api-call branch from 93ec7cf to d8bccb0 Compare July 16, 2026 20:50
@nschad

nschad commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

/unhold

@ske-prow ske-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2026
@nschad
check vol status before trying to attach; abort early if status is no…
c691c11 
…t happy

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad
nschad force-pushed the drop-unnecessary-api-call branch from d8bccb0 to c691c11 Compare July 16, 2026 20:53
@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xoxys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2026
@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 0abd1e7eaa41b6e15495f08e7d60be03c14d8a1a

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2026
@ske-prow
ske-prow Bot merged commit a1848e4 into main Jul 17, 2026
3 checks passed
@ske-prow
ske-prow Bot deleted the drop-unnecessary-api-call branch July 17, 2026 12:31
@nschad

nschad commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

@stackit-ske

stackit-ske commented Jul 17, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1379

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jul 17, 2026
Merged
@stackit-ske

stackit-ske commented Jul 17, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1380

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jul 17, 2026
Merged
@stackit-ske

stackit-ske commented Jul 17, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1381

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jul 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dergeberl dergeberl dergeberl left review comments
@xoxys xoxys xoxys approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nschad @stackit-ske @xoxys @dergeberl