Skip to content

Also fetch backups when fetching snapshots#1335

Merged
ske-prow[bot] merged 4 commits into
mainfrom
e2e-tests
Jul 17, 2026
Merged

Also fetch backups when fetching snapshots#1335
ske-prow[bot] merged 4 commits into
mainfrom
e2e-tests

Conversation

@breuerfelix

@breuerfelix breuerfelix commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind regression
What this PR does / why we need it:
The type backup for snapshots never worked since ListSnapshots has to fetch backups aswell, not only snapshots. This also never worked for openstack but is now at least fixed for the stackit CSI.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

/hold needs testing

@ske-prow ske-prow Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 8, 2026
@breuerfelix
also fetch backups when fetching snapshots
04d1ee9 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@ske-prow ske-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 8, 2026
@breuerfelix
remove pagination
f4bd9af 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@breuerfelix
fix linting issues
00e37ba 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@breuerfelix

breuerfelix commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

/unhold

image

@ske-prow ske-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2026
@breuerfelix
breuerfelix requested a review from a team July 8, 2026 14:41
@breuerfelix breuerfelix mentioned this pull request Jul 15, 2026
Closed
nschad
nschad reviewed Jul 16, 2026
View reviewed changes
Comment thread pkg/csi/blockstorage/controllerserver.go Outdated
@breuerfelix
remove sorting
7b11d95 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nschad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2026
@ske-prow

ske-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: f5c3aa3bf73c452499f02889e13ef1894cbf5605

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2026
@nschad

nschad commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

@stackit-ske

stackit-ske commented Jul 17, 2026

Copy link
Copy Markdown

@nschad: once the present PR merges, I will cherry-pick it on top of release-v1.34, release-v1.35, release-v1.36 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow
ske-prow Bot merged commit a3a06e5 into main Jul 17, 2026
3 checks passed
@ske-prow
ske-prow Bot deleted the e2e-tests branch July 17, 2026 13:20
@stackit-ske

stackit-ske commented Jul 17, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1382

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jul 17, 2026
Merged
@stackit-ske

stackit-ske commented Jul 17, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1383

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jul 17, 2026
Merged
@stackit-ske

stackit-ske commented Jul 17, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1384

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jul 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschad nschad nschad approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@breuerfelix @nschad @stackit-ske