Add support for Rocky Linux 9.8#2349
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various package repository versions, kolla image tags, and introduces support for Rocky Linux 9.8, including a temporary workaround in kolla-build.conf for missing 9.8 container images. Feedback points out an inconsistency in pulp.yml where the documentation comment states the default Rocky 9 minor version is 8, but the variable remains configured as '7'.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # Rocky 9 minor version number. Supported values: 6, 7, 8. Default is 8. | ||
| stackhpc_pulp_repo_rocky_9_minor_version: '7' |
There was a problem hiding this comment.
The comment states that the default minor version is 8, but the variable stackhpc_pulp_repo_rocky_9_minor_version is still set to '7'. To align with the comment and default to Rocky Linux 9.8, the variable should be updated to '8'.
# Rocky 9 minor version number. Supported values: 6, 7, 8. Default is 8.
stackhpc_pulp_repo_rocky_9_minor_version: '8'References
- When documenting supported values for a variable, ensure all currently supported values are listed to avoid confusion, even if a new default is introduced.
There was a problem hiding this comment.
The bot seems to be correct
| # Rocky 9 minor version number. Supported values: 6, 7, 8. Default is 8. | ||
| stackhpc_pulp_repo_rocky_9_minor_version: '7' |
There was a problem hiding this comment.
The bot seems to be correct
| stackhpc_pulp_repo_ubuntu_cloud_archive_version: 20260603T234508 | ||
| stackhpc_pulp_repo_ubuntu_noble_security_version: 20260604T023511 | ||
| stackhpc_pulp_repo_ubuntu_noble_version: 20260604T023511 |
There was a problem hiding this comment.
Are you purposefully rebuilding ubuntu as well?
There was a problem hiding this comment.
Yes, because I bumped all third-party repositories too. And this way we are sure the OpenStack code is the same across all distributions.
github-actions
Bot
added
the
waiting-author-response
|
Happy Friday @priteau, this is a friendly reminder that this PR is waiting for your changes or response. Please take a look when you have a moment! Note: Once your changes are ready, remove the |
2 participants
No description provided.