Build DOCA-OFED kernel modules for Rocky 10#2310
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for DOCA OFED on Rocky Linux 10 for both x86_64 and aarch64 architectures. The changes involve updating repository configurations, kernel version matrices, and adding retry logic for Pulp-related tasks. Feedback focuses on improving maintainability and consistency by replacing hardcoded version strings with variables in repository definitions and variable names. Additionally, it is recommended to use kolla_base_arch instead of os_arch in push-ofed.yml to ensure correct repository selection during cross-architecture builds and to maintain consistency in failure messages.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for DOCA OFED on Rocky Linux 10 for both x86_64 and aarch64 architectures. Key changes include updating the DOCA version matrix, refactoring repository lookups to be more dynamic, and adding Pulp repository configurations and DNF custom repositories for RHEL 10. Feedback focuses on correcting the use of non-standard architecture variables, ensuring Ansible retry logic is correctly implemented with 'until' and 'delay' parameters, and utilizing generic version variables in repository URLs to improve maintainability.
DOCA OFED support has now been added for Rocky 10: * Build workflow updated to include Rocky 10 (x86_64 and aarch64 builds) * Rocky 9.6 to 9.7 OFED upgrade playbook hardcoded to use 9.7 kernel * Installation playbook now uses host distribution version * Retries added to pulp pushing playbook * Pulp pushing playbook can now handle multiple OFED repositories (for Rocky 9 and 10) being defined * Updates to Pulp, repository and OFED tag definitions, to handle both Rocky 9 and 10
DOCA OFED support has now been added for Rocky 10:
Successful build
Testing the new kernel modules on Rocky 10 has not yet been possible, this will be done once baremetal mellanox is available on smslab.