Ci hardening - #608
Open
Saul-STFC wants to merge 4 commits into
Open
Conversation
* ci: Bump actions/checkout to v7.0.0 * ci: Add explicit permissions to jobs * ci: Conditionally install host dependencies without cache * ci: Conditionally set rust-cache lookup-only * ci: Skip publish jobs for forks * ci: Remove checkout step from notify job
Techassi
self-requested a review
July 14, 2026 18:10
* Prevent notification on cancelled workflows * Update failure condition to check job results * Add missing job dependencies to notify job * Validate required jobs in finished job * Fix detect-changes globs to cover subdirectory Rust sources * Match dependency versions across templates * Guard publish/provenance jobs with stackabletech owner check * Fix daily security workflow
Techassi
reviewed
Aug 4, 2026
Techassi
left a comment
Techassi
left a comment
Member
There was a problem hiding this comment.
Overall looks good to me, thanks!
Just a few minor comments.
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| checks: write |
Member
There was a problem hiding this comment.
I think we should leave a comment here explaining why we need this permission.
| if [ "$EVENT_NAME" = "schedule" ]; then | ||
| AUTHOR="stackabletech/developers" | ||
| REASON="Weekly run triggered" | ||
| else |
Member
There was a problem hiding this comment.
We previously explicitly matched on schedule XOR workflow_dispatch. We should do the same here and fallback to exiting with non-0 if the trigger is neither of the two options.
| --arg author "$AUTHOR" \ | ||
| --arg reason "$REASON" \ | ||
| --arg custom_pr_title "$CUSTOM_PR_TITLE" \ | ||
| --arg base_dir "$(pwd)" \ |
Member
There was a problem hiding this comment.
Mhm, curious. This expands to nothing because the correct thing to do here would be ${PWD}.
| name: Publish/Sign ${{ needs.build-container-image.outputs.operator-version }} Index | ||
| if: | | ||
| (github.event_name != 'merge_group') | ||
| github.repository_owner == 'stackabletech' |
Member
There was a problem hiding this comment.
I think this replaces !github.event.pull_request.head.repo.fork below, right?
More of these would need to be changed below if that is the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a collection of 'correctness fixes' and 'hygiene' improvements to the CI templates:
Including: