chore: Make cargo doc fail on warnings - #1277
Merged
Merged
Conversation
Techassi
added
the
release-retro/26.7.0
Techassi
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
NickLarsenNZ
previously approved these changes
Sep 21, 2026
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
Hmm, I find warnings useful for deprecating things without a breaking change.
I'll approve it since we already do that, but we should maybe look at relaxing that rule (it could be a separate check that is allowed to fail so at least there is feedback).
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Member
Author
|
I don't know if the deprecation warnings even apply to If they do, I don't know if there maybe is a way to allow specific warnings but denying the rest. I guess that would be ideal to allow warnings from |
…go-doc-fail-on-warnings
NickLarsenNZ
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by stackabletech/issues#848 (comment), similar to stackabletech/operator-templating#650.
cargo dochooks run by prek now error on warnings.