test: Verify "Finished Build and Publish" gate catches failures (DO NOT MERGE) - #415
Draft
lfrancke wants to merge 1 commit into
Draft
test: Verify "Finished Build and Publish" gate catches failures (DO NOT MERGE)#415lfrancke wants to merge 1 commit into
lfrancke wants to merge 1 commit into
Conversation
DO NOT MERGE. Test branch for stackabletech/operator-templating#614. - Apply the fixed `finished` gate (if: always() + explicit result check + all leaf jobs as direct needs). - Temporarily force publish-index-manifest to fail, reproducing the bug where the gate was skipped (and thus treated as passing by branch protection). With the fix, the gate must now report failure. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. Test branch for stackabletech/operator-templating#614.
Purpose
Verify the fixed
Finished Build and Publishgate on a real operator repo before rolling the template change out everywhere (per @NickLarsenNZ's request on operator-templating#614).What this branch does
finishedgate to.github/workflows/build.yaml:if: always()so the gate always runs and reports a real success/failure conclusion.needs.failure/cancelledresult, tolerating legitimateskipped.publish-index-manifestto fail (a throwawayexit 1step), reproducing the exact bug from listener-operator run 29825092091.Expected result (proves the fix)
Publish/Sign … Index→ failureRun OpenShift Preflight Check→ skipped (cascade)Finished Build and Publish→ failure ✅ (previously this was skipped, which branch protection treated as passing → broken build was mergeable)The PR should show as not mergeable / checks failing. That's success for this test.
After confirming, drop the forced-failure commit to check the gate goes green on a clean run, then close this PR without merging.
🤖 Generated with Claude Code