Skip to content

fix(java-devel): Apply Maven retry settings under connector.* keys used by Maven 3.9#1591

Merged
Techassi merged 1 commit into
mainfrom
fix/maven-retry-connector-keys
Jul 21, 2026
Merged

fix(java-devel): Apply Maven retry settings under connector.* keys used by Maven 3.9#1591
Techassi merged 1 commit into
mainfrom
fix/maven-retry-connector-keys

Conversation

@lfrancke

@lfrancke lfrancke commented Jul 21, 2026

Copy link
Copy Markdown
Member

Description

In #1584 @Techassi added HTTP retry settings to java-devel/stackable/settings.xml, but only under the aether.transport.http.* keys. That prefix is the maven-resolver 2.x / Maven 4 spelling. We build with Maven 3.9.16 (maven-resolver 1.9.27), which only reads `aether.connector.http.*. So those retry settings currently have no effect. I diagnosed that years ago and we even have a comment in the file about it.

This adds the connector.* spelling alongside the existing transport.* one, so the retries actually apply today, mirroring how connectionMaxTtl is already dual-spelled in the same file. The transport.* keys are kept for the eventual Maven 4 upgrade.

@lfrancke
lfrancke force-pushed the fix/maven-retry-connector-keys branch from bb3c64f to fc3e217 Compare July 21, 2026 14:00
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Jul 21, 2026
@lfrancke lfrancke self-assigned this Jul 21, 2026
Techassi
Techassi previously approved these changes Jul 21, 2026

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just a minor comment about the changelog.

Comment thread CHANGELOG.md Outdated
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 21, 2026
…ed by Maven 3.9

#1584 added HTTP retry settings (retryHandler.count/interval/intervalMax) under the aether.transport.http.* keys. That prefix is the maven-resolver 2.x / Maven 4 spelling; we build with Maven 3.9.16 (maven-resolver 1.9.27), which only reads aether.connector.http.*, so those settings currently have no effect.

Add the connector.* spelling alongside the transport.* one so the retries actually apply today, mirroring how connectionMaxTtl is already dual-spelled.

CI Maven failures are connection-level (stale keep-alive connections dropped by the network; no server-side 5xx in Nexus/Apache logs). maven-resolver's retry handler retries these IOExceptions, so this makes the intended retry behaviour effective. Key names verified against ConfigurationProperties.java @ maven-resolver-1.9.27.
@lfrancke
lfrancke force-pushed the fix/maven-retry-connector-keys branch from fc3e217 to 592335f Compare July 21, 2026 14:26
@lfrancke

Copy link
Copy Markdown
Member Author

Thanks! Rebased onto main (past #1590's release changelog update) and removed the changelog entry — consistent with #1584/#1585, which didn't have one either, and it avoids a release-branch cherry-pick. The PR is now just the settings.xml fix.

@Techassi

Copy link
Copy Markdown
Member

I would hold off on merging this for a little while until the 26.7.0 images are out of the door.

@Techassi
Techassi added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit de5c21f Jul 21, 2026
3 checks passed
@Techassi
Techassi deleted the fix/maven-retry-connector-keys branch July 21, 2026 18:27
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jul 22, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants