fix(java-devel): Apply Maven retry settings under connector.* keys used by Maven 3.9#1591
Merged
Merged
Conversation
lfrancke
force-pushed
the
fix/maven-retry-connector-keys
branch
from
July 21, 2026 14:00
bb3c64f to
fc3e217
Compare
Techassi
previously approved these changes
Jul 21, 2026
Techassi
left a comment
Member
There was a problem hiding this comment.
Lgtm, just a minor comment about the changelog.
…ed by Maven 3.9 #1584 added HTTP retry settings (retryHandler.count/interval/intervalMax) under the aether.transport.http.* keys. That prefix is the maven-resolver 2.x / Maven 4 spelling; we build with Maven 3.9.16 (maven-resolver 1.9.27), which only reads aether.connector.http.*, so those settings currently have no effect. Add the connector.* spelling alongside the transport.* one so the retries actually apply today, mirroring how connectionMaxTtl is already dual-spelled. CI Maven failures are connection-level (stale keep-alive connections dropped by the network; no server-side 5xx in Nexus/Apache logs). maven-resolver's retry handler retries these IOExceptions, so this makes the intended retry behaviour effective. Key names verified against ConfigurationProperties.java @ maven-resolver-1.9.27.
lfrancke
force-pushed
the
fix/maven-retry-connector-keys
branch
from
July 21, 2026 14:26
fc3e217 to
592335f
Compare
Member
Author
Techassi
approved these changes
Jul 21, 2026
Member
|
I would hold off on merging this for a little while until the 26.7.0 images are out of the door. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #1584 @Techassi added HTTP retry settings to
java-devel/stackable/settings.xml, but only under theaether.transport.http.*keys. That prefix is the maven-resolver 2.x / Maven 4 spelling. We build with Maven 3.9.16 (maven-resolver 1.9.27), which only reads `aether.connector.http.*. So those retry settings currently have no effect. I diagnosed that years ago and we even have a comment in the file about it.This adds the
connector.*spelling alongside the existingtransport.*one, so the retries actually apply today, mirroring howconnectionMaxTtlis already dual-spelled in the same file. Thetransport.*keys are kept for the eventual Maven 4 upgrade.