Skip to content

feat: Implement restarter.stackable.tech/ignore label#410

Merged
siegfriedweber merged 20 commits intomainfrom
feat/ignore-restarter
Apr 15, 2026
Merged

feat: Implement restarter.stackable.tech/ignore label#410
siegfriedweber merged 20 commits intomainfrom
feat/ignore-restarter

Conversation

@siegfriedweber
Copy link
Copy Markdown
Member

@siegfriedweber siegfriedweber commented Mar 23, 2026

Description

Support the label restarter.stackable.tech/ignore on ConfigMaps and Secrets and the annotations restarter.stackable.tech/ignore-configmap.x and restarter.stackable.tech/ignore-secret.x on StatefulSets to exclude ConfigMaps and Secrets from the restarter controller.

Rust edition updated to version 2024 to be able to use if-let-chains.

Part of stackabletech/issues#837

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber siegfriedweber added release-note Denotes a PR that will be considered when it comes time to generate release notes. scheduled-for/26.7.0 labels Apr 1, 2026
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Apr 2, 2026
@siegfriedweber siegfriedweber marked this pull request as ready for review April 2, 2026 14:00
@siegfriedweber siegfriedweber requested a review from sbernauer April 2, 2026 14:00
@sbernauer sbernauer changed the title feat: Implement annotation restarter.stackable.tech/ignore feat: Implement restarter.stackable.tech/ignore label Apr 7, 2026
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits, only one concern about the watcher and label

Comment thread Cargo.toml
Comment thread docs/modules/commons-operator/pages/restarter.adoc Outdated
Comment thread rust/operator-binary/src/restart_controller/statefulset.rs
Comment thread rust/operator-binary/src/restart_controller/statefulset.rs Outdated
Comment thread CHANGELOG.md Outdated
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 10, 2026
siegfriedweber and others added 5 commits April 13, 2026 09:17
sbernauer
sbernauer previously approved these changes Apr 13, 2026
@siegfriedweber siegfriedweber added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 2822e09 Apr 15, 2026
12 checks passed
@siegfriedweber siegfriedweber deleted the feat/ignore-restarter branch April 15, 2026 13:37
@siegfriedweber
Copy link
Copy Markdown
Member Author

Release notes

Platform improvements

General

Miscellaneous

@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. scheduled-for/26.7.0

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants