Skip to content

Refactor#9

Merged
ssbssa merged 1 commit into
ssbssa:masterfrom
oltolm:refactor
May 6, 2026
Merged

Refactor#9
ssbssa merged 1 commit into
ssbssa:masterfrom
oltolm:refactor

Conversation

@oltolm
Copy link
Copy Markdown
Contributor

@oltolm oltolm commented May 6, 2026

Two trivial patches. One renames "walkChilds" to "walkChildren" another removes two unneeded variables.

@ssbssa
Copy link
Copy Markdown
Owner

ssbssa commented May 6, 2026

The renaming I don't really mind, but the lowpc/highpc variables are not the same exact type as the low/high variables (even if their typedef points to the same type).

@oltolm
Copy link
Copy Markdown
Contributor Author

oltolm commented May 6, 2026

I noticed that too. dwarf_get_rnglists_entry_fields_a expects Dwarf_Unsigned, but later low and high are compared to cuInfo->ptr which is a Dwarf_Addr. The existing code is already inconsistent.

@ssbssa
Copy link
Copy Markdown
Owner

ssbssa commented May 6, 2026

My point is that I have to supply variables of the matching type as arguments to dwarf_get_rnglists_entry_fields_a.

@oltolm
Copy link
Copy Markdown
Contributor Author

oltolm commented May 6, 2026

I dropped the patch that removed the variables.

@ssbssa ssbssa merged commit 686599f into ssbssa:master May 6, 2026
1 check failed
@oltolm oltolm deleted the refactor branch May 6, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants