Fix support for squidconf directive parameter files (#2458)#2459
Merged
Conversation
…-cache#2458) Those files were never found. 2022 commit d37a374 probably missed this bug because the corresponding `squid -k parse` failures (quoted below) do not result in non-zero exit status code. That failure handling problem deserves a dedicated fix. ERROR: Can not open file empty.conf for reading configuration context: ./squidconf/regressions-3.4.0.1.conf(27)
squid-anubis
added
the
M-failed-description
This comment was marked as resolved.
This comment was marked as resolved.
yadij
changed the title
squid-anubis
removed
the
M-failed-description
yadij
approved these changes
Jul 14, 2026
squid-anubis
added
the
M-merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those files were never found. 2022 commit d37a374 probably missed this
bug because the corresponding
squid -k parsefailures (quoted below)do not result in non-zero exit status code. That failure handling
problem deserves a dedicated fix.