fix(ci): capture digest from helm stderr output#217
Merged
Conversation
squat
approved these changes
May 15, 2026
Owner
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
thanks! I was wondering why i couldn't reproduce this locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
third time's the charm
fixes https://github.com/squat/generic-device-plugin/actions/runs/25805893711/job/75810381088
Helm weirdly outputs everything to stderr on push so the output was never captured into the variable. Looks like it will be swapped back to stdout with this helm/helm#32056 but in the meantime pointing everything to stdout works and won't break if it changes again.
I also unpinned the helm version since it's 2 years old 😄 I didn't see a way to have it tracked with your dependabot config.
Thanks!