Skip to content

Google Search Console v1.0.1: clarify accepted property types (URL-prefix & Domain)#99

Open
Daniel-Hodgson-SquaredUp wants to merge 2 commits into
mainfrom
update-gsc-plugin
Open

Google Search Console v1.0.1: clarify accepted property types (URL-prefix & Domain)#99
Daniel-Hodgson-SquaredUp wants to merge 2 commits into
mainfrom
update-gsc-plugin

Conversation

@Daniel-Hodgson-SquaredUp

@Daniel-Hodgson-SquaredUp Daniel-Hodgson-SquaredUp commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📋 Summary

Clarifies that the Google Search Console data source accepts both Search Console property types:

  • URL-prefix (https://example.com/)
  • Domain (sc-domain:example.com)

Previously the field label, help text and docs only referenced URL-prefix properties, so owners of a Domain property hit a 403 "insufficient permission" error despite having access, because they were entering the URL form for a property that is only addressable via sc-domain:.

Changes:

  • Relabel the config field Search Console property URLSearch Console property, and rewrite its help + placeholder to cover both formats (ui.json).
  • Update docs: prerequisites, a new Which property value to use section, the config/example tables, and a troubleshooting note for the 403-from-wrong-property-type case (docs/README.md).
  • Bump version 1.0.01.0.1 (metadata.json).

No behavioural change. siteUrl is still passed through untouched (the plugin already accepted sc-domain: values); this only documents and surfaces it.


🔗 Related issue(s)

N/A. Surfaced by a user hitting the 403 on a Domain property.


🧩 Plugin details

  • Plugin name: Google Search Console
  • Type of change:
    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo
    • Other (please describe):

⚠️ Breaking changes

  • No

📚 Documentation

  • Documentation updated

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

Summary by CodeRabbit

  • Documentation
    • Clarified that setup requires a verified Search Console property (not limited to URL-prefix).
    • Updated configuration guidance to support both URL-prefix identifiers (including trailing slash) and Domain identifiers (sc-domain:…), with revised examples.
    • Improved troubleshooting notes to stress exact identifier matching and added guidance for common 403 insufficient-permission cases (often caused by using the wrong property type).
  • Chores
    • Bumped the GoogleSearchConsole plugin version to 1.0.1.

Update the property field label/help and docs to explain that both
URL-prefix (https://example.com/) and Domain (sc-domain:example.com)
properties are accepted, and add a troubleshooting note for the 403
"insufficient permission" error caused by using the wrong property type.
Bump version to 1.0.1.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Daniel-Hodgson-SquaredUp
Daniel-Hodgson-SquaredUp requested a review from a team July 22, 2026 13:30
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: ec438364-815a-463c-b87e-38db777de8d5

📥 Commits

Reviewing files that changed from the base of the PR and between ba4949b and 2ccfca8.

📒 Files selected for processing (1)
  • plugins/GoogleSearchConsole/v1/docs/README.md

📝 Walkthrough

Walkthrough

Google Search Console property configuration now supports URL-prefix and Domain identifiers. Documentation, UI guidance, examples, troubleshooting, and plugin metadata were updated.

Changes

Google Search Console property identifiers

Layer / File(s) Summary
Property identifier guidance and release metadata
plugins/GoogleSearchConsole/v1/docs/README.md, plugins/GoogleSearchConsole/v1/ui.json, plugins/GoogleSearchConsole/v1/metadata.json
Documentation and UI metadata describe URL-prefix values with trailing slashes and Domain values using sc-domain:; examples and troubleshooting were updated, and the plugin version changed to 1.0.1.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and accurately summarizes the main change: clarifying accepted Google Search Console property types in v1.0.1.
Description check ✅ Passed The description is mostly complete, covering summary, issue context, plugin details, breaking changes, documentation, and checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/GoogleSearchConsole/v1/docs/README.md`:
- Line 113: Update the end of the README file so it terminates with exactly one
trailing newline, resolving the Markdownlint MD047 violation without changing
the documented content.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: a96bc224-4e04-47d1-a4fa-d76fe828dc9b

📥 Commits

Reviewing files that changed from the base of the PR and between 2c93cd8 and ba4949b.

📒 Files selected for processing (3)
  • plugins/GoogleSearchConsole/v1/docs/README.md
  • plugins/GoogleSearchConsole/v1/metadata.json
  • plugins/GoogleSearchConsole/v1/ui.json

Comment thread plugins/GoogleSearchConsole/v1/docs/README.md Outdated
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/GoogleSearchConsole/v1

📋 Results

Step Status
Validation ✅ Passed
Deployment 🚀 Deployed

🔍 Validation Details

google-search-console
{
  "valid": true,
  "pluginName": "google-search-console",
  "pluginType": "hybrid",
  "summary": {
    "Data Streams": 14,
    "Import Definitions": 1,
    "UI Configuration": true,
    "Has Icon": true,
    "Has Default Content": true,
    "Config Validation": false,
    "Custom Types": false
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant