Google Search Console v1.0.1: clarify accepted property types (URL-prefix & Domain)#99
Google Search Console v1.0.1: clarify accepted property types (URL-prefix & Domain)#99Daniel-Hodgson-SquaredUp wants to merge 2 commits into
Conversation
Update the property field label/help and docs to explain that both URL-prefix (https://example.com/) and Domain (sc-domain:example.com) properties are accepted, and add a troubleshooting note for the 403 "insufficient permission" error caused by using the wrong property type. Bump version to 1.0.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughGoogle Search Console property configuration now supports URL-prefix and Domain identifiers. Documentation, UI guidance, examples, troubleshooting, and plugin metadata were updated. ChangesGoogle Search Console property identifiers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/GoogleSearchConsole/v1/docs/README.md`:
- Line 113: Update the end of the README file so it terminates with exactly one
trailing newline, resolving the Markdownlint MD047 violation without changing
the documented content.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: a96bc224-4e04-47d1-a4fa-d76fe828dc9b
📒 Files selected for processing (3)
plugins/GoogleSearchConsole/v1/docs/README.mdplugins/GoogleSearchConsole/v1/metadata.jsonplugins/GoogleSearchConsole/v1/ui.json
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🧩 Plugin PR Summary📦 Modified Plugins
📋 Results
🔍 Validation Details✅
|
📋 Summary
Clarifies that the Google Search Console data source accepts both Search Console property types:
https://example.com/)sc-domain:example.com)Previously the field label, help text and docs only referenced URL-prefix properties, so owners of a Domain property hit a
403 "insufficient permission"error despite having access, because they were entering the URL form for a property that is only addressable viasc-domain:.Changes:
Search Console property URL→Search Console property, and rewrite its help + placeholder to cover both formats (ui.json).docs/README.md).1.0.0→1.0.1(metadata.json).No behavioural change.
siteUrlis still passed through untouched (the plugin already acceptedsc-domain:values); this only documents and surfaces it.🔗 Related issue(s)
N/A. Surfaced by a user hitting the 403 on a Domain property.
🧩 Plugin details
📚 Documentation
✅ Checklist
Summary by CodeRabbit
sc-domain:…), with revised examples.