Skip to content

add us2 region for NinjaOne #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deenk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add us2 region for NinjaOne #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeab67e
add us2 region
Deenk Jun 5, 2026
02fec4f
correct url for us2
Deenk Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/NinjaOne/v1/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ninja-one",
"displayName": "NinjaOne",
"version": "1.1.11",
"version": "1.1.12",
"author": {
"name": "SquaredUp Labs",
"type": "labs"
Expand Down
4 changes: 4 additions & 0 deletions plugins/NinjaOne/v1/ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
"value": "https://api.ninjarmm.com",
"label": "US"
},
{
"value": "https://api.us2.ninjarmm.com",
"label": "US2"
},

Check warning on line 16 in plugins/NinjaOne/v1/ui.json

View check run for this annotation

Claude / Claude Code Review

README not updated to reflect new US2 region 

The README enumerates only "US, EU, Canada, or OC" as available regions and was not updated to include the new US2 option added in ui.json. Since `docs/README.md` is rendered in-product during plugin setup, a US2 customer reading these docs may incorrectly conclude their region is unsupported. Fix by updating line 24 to read `(US, US2, EU, Canada, or OC)`.
Comment on lines +13 to +16
Copy link
Copy Markdown

@claude claude Bot Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The README enumerates only "US, EU, Canada, or OC" as available regions and was not updated to include the new US2 option added in ui.json. Since docs/README.md is rendered in-product during plugin setup, a US2 customer reading these docs may incorrectly conclude their region is unsupported. Fix by updating line 24 to read (US, US2, EU, Canada, or OC).

Extended reasoning...

What the bug is

This PR adds US2 as a fifth region option in plugins/NinjaOne/v1/ui.json (lines 13-16), but plugins/NinjaOne/v1/docs/README.md was not updated. Line 24 still reads:

  1. Region: Select your NinjaOne instance region (US, EU, Canada, or OC). The API URL will be automatically configured based on your selection.

The PR checklist marks No documentation changes needed, but the README explicitly enumerates the available regions rather than describing them generically, so the new option needs to be added to keep the docs in sync with the UI.

Why this matters

The README in plugins/NinjaOne/v1/docs/ is shown in-product to users during plugin configuration (it powers the "Help adding this plugin" link referenced in metadata.json and is rendered in the configuration UI). A US2 customer — exactly the customer this PR is trying to unblock per PLUG-4644 — could read this enumeration during setup and conclude their region is not supported, defeating the user-facing goal of the PR.

Step-by-step proof

  1. A US2 NinjaOne customer opens the plugin configuration screen in SquaredUp.
  2. They click the "Help adding this plugin" link (defined in metadata.json links), or read the embedded help text.
  3. They see: "Select your NinjaOne instance region (US, EU, Canada, or OC)."
  4. Their region (US2) is not in the list, so they conclude the plugin doesn't support US2.
  5. They abandon the setup — even though the dropdown in ui.json now does in fact include US2 with https://api.us2.ninjarmm.com.

Impact

Cosmetic / documentation only — the radio button in ui.json is authoritative and a customer who looks at the dropdown directly will see US2. Functionality is not broken. Hence nit severity. But this directly contradicts the PR's stated user-facing goal of making US2 reachable, so it's worth fixing in this same PR.

How to fix

Update plugins/NinjaOne/v1/docs/README.md line 24 to include US2 in the enumeration:

1. **Region**: Select your NinjaOne instance region (US, US2, EU, Canada, or OC). The API URL will be automatically configured based on your selection.

No other documentation changes appear necessary — US2 doesn't require a separate setup flow, just a different base URL, which the existing prose already covers.

{
"value": "https://eu-api.ninjarmm.com",
"label": "EU"
Expand Down
Loading