Skip to content

Preserve transparent favicons and remove redundant hero CTA - #3

Merged
kvlonge merged 1 commit into
mainfrom
fix/transparent-favicon
Nov 1, 2026
Merged

kvlonge merged 1 commit into
mainfrom
fix/transparent-favicon

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove only the white favicon backing, retaining the existing raster mark and transparent ICO/PNG fallbacks.
  • Select the light or white favicon using the browser system preference, independently of an explicit page-theme override.
  • Remove the redundant Find a tool hero link and its unused styles, retaining the centred View on GitHub action and accessible Skip to tools navigation.

Verification

  • All four Playwright tests pass, including system/page theme independence, transparent favicon pixels, keyboard navigation and responsive widths from 320 to 1536px.
  • Inspected actual Chrome tab captures at 16px and 32px in light/dark chrome, plus desktop/narrow-page screenshots in both themes.
  • JavaScript syntax, diff whitespace and public-repository hygiene checks pass.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying sqlstack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 26051e5
Status: ✅  Deploy successful!
Preview URL: https://97b28468.sqlstack.pages.dev
Branch Preview URL: https://fix-transparent-favicon.sqlstack.pages.dev

View logs

@kvlonge
kvlonge merged commit 5951d6c into main Nov 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant