Repository navigation
feat!: name built-in Rules SQLCLEAN and own the host contract - #17
Merged
Merged
Conversation
Deploying sqlclean with
|
| Latest commit: |
194262c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e33963d2.sqlclean.pages.dev |
| Branch Preview URL: | https://feat-sqlclean-codes.sqlclean.pages.dev |
Built-in Rule codes are SQLCLEANnnn instead of SQCnnn, custom Rule codes start with XSQLCLEAN, and the parse error is SQLCLEAN999. The embedding API no longer carries SQLBuild names. Hosts write the SQLClean placeholder prefixes exported from constants, describe a test or macro wrapper with one fixture_harness request object instead of allows_ceremonial_select and allows_empty_fixture_star, and derive relation_keys themselves: DeclaredRelation and declared_relation_keys are removed. BREAKING CHANGE: SQC and XSQC codes are now SQLCLEAN and XSQLCLEAN, and the lint request replaces the two harness flags with fixture_harness. Co-authored-by: Kevin Longe <kvlonge@gmail.com>
kvlonge
force-pushed
the
feat/sqlclean-codes
branch
from
October 31, 2026 12:21
40d8d5b to
194262c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLBuild will lint and format through this crate, so SQLClean must own one canonical contract: its own Rule codes, and a host API without SQLBuild names baked in.
Changes
SQCnnnbecomeSQLCLEANnnn(same numbers), custom codesXSQC...becomeXSQLCLEAN..., the parse error isSQLCLEAN999. No aliases.selectruns the default Rules,SQLCLEANselects every built-in Rule, an exact code selects one.INTERPOLATION_PLACEHOLDER_PREFIXand three more) instead of hard-coded__sqb_lint_/__sqlbuild_*names.fixture_harnessrequest object (cte_prefixes,input_cte_prefixes,empty_relation) replacesallows_ceremonial_select,allows_empty_fixture_starand the hard-coded harness CTE names.DeclaredRelation/declared_relation_keys(incremental and audit key semantics) are removed; hosts passrelation_keys.relation_keysmatches; Rule docs, skill, README, benchmarks script and the demo GIF use the new codes.Verification
make verify(fensu 0 faults, clippy on 1.95 and 1.99), integration and e2e suites, hygiene scan.SQLCLEAN005,SQLCLEAN001,XSQLCLEANTEAM001, fixes apply.