Repository navigation
ci(performance): restore the 1.10 cold limit of the fresh ratio - #1287
Merged
Merged
Conversation
Main now runs the default SQL Rules, so both sides of the same-runner fresh comparison pay their cost. Remove the temporary 1.25 wall and 1.41 CPU cold allowance and the cold-only ratio options that existed for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#1283 gave the same-runner fresh ratio a temporary cold allowance (1.25 wall, 1.41 CPU) because its base, main, did not run the default SQL Rules yet. Main now runs them, so both sides pay the same cost and the allowance would only hide regressions.
Changes
--cold-max-ratioand--cold-max-cpu-ratiooptions, which existed only for the allowance.verify.ymlandcompare.pynow match their state before feat(rules): run SQL Rules through the SQLClean engine #1283.Verification
fensu check: 0 faults. Ratio script unit tests pass (32).verify.ymlparses.