Repository navigation
feat: answer simple commands in sqb, upgrade fensu and accept SharedMergeTree - #1170
Merged
Merged
Conversation
…hed capture A write that reached a capture already marked complete built its rejection while still holding the storage lock. Building it imports Python, which can release the GIL; the main thread then pruning the logs waited for that lock while holding the GIL, so neither could continue and the command never exited. The lock is now released before the rejection is raised.
…alling the job run_sqb now gives each command ten minutes. A command still running then has its process group aborted with Python's fault handler enabled, so the failing test reports every thread's stack, and the group is killed. Standard input ends at once when a test passes none.
… in sqb without Python
Shared* MergeTree engines now pass model validation like their MergeTree counterparts. Replicated* engines stay rejected. Support is best effort and untested on ClickHouse Cloud.
…' into feat/combined-batch
…feat/combined-batch
kvlonge
enabled auto-merge (squash)
October 19, 2026 23:34
Opening several connections to a new file at once could fail with A702 at once: SQLite reports the WAL switch as busy without waiting while another connection switches the same file. The switch now goes through the per-file writer gate. Also give wheel builds 75 minutes, since the Intel macOS build reached the 45-minute limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three ready changes, combined so they share one CI run: Python-free
sqbcommands, the fensu 0.27 upgrade with dead-code enforcement, and ClickHouse CloudSharedMergeTreeengines being rejected.Changes
sqbanswers help, version, usage errors,init,skills,cleanandrules list|showwithout Python (decided before any side effect; anything unusual still runs Python). Output, exit codes and compute logs match the Python CLI; Ctrl+C ends by SIGINT.Shared*MergeTree engines are accepted like their MergeTree counterparts (best effort, untested on ClickHouse Cloud).Verification
--help97 → 11 ms,rules list177 → 43 ms.make testpassed.fensu check, compiler differential, the PRs' focused tests andmake check-ci.