Repository navigation
Conversation
Shared* MergeTree engines now pass model validation like their MergeTree counterparts. Replicated* engines stay rejected. Support is best effort and untested on ClickHouse Cloud.
kvlonge
enabled auto-merge (squash)
October 19, 2026 22:17
Contributor
Author
|
Closing in favour of one combined PR (H2 + fensu 0.27 + SharedMergeTree on top of the merged deadlock fix) so these share a single CI run; the branch is being fixed for an interaction between H2's broken-pipe parity tests and the merged changes. |
auto-merge was automatically disabled
October 19, 2026 23:21
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ClickHouse Cloud uses the
SharedMergeTreeengine family. Model validation rejected everyShared*engine name, so a model could not nameSharedMergeTreeorSharedReplacingMergeTreeexplicitly, even though Cloud already turns a plainMergeTreeintoSharedMergeTree.Changes
Shared*MergeTree-family engines like theirMergeTreecounterparts.Replicated*engines and engines outside the MergeTree family are still rejected; the error now says "non-replicated MergeTree-family".CREATE TABLE ... AS,ATTACH/REPLACE PARTITION ... FROMandEXCHANGE TABLES, which copy the source table's engine. Shared tables therefore take the same paths as MergeTree tables.FINALreads come from the sourcefinalflag, not the engine name.Shared*engines as accepted, best effort and untested on ClickHouse Cloud. Skill reference pages are regenerated.Verification
cargo test -p sqlbuild-model-config physical_storage: Shared variants accepted,ReplicatedReplacingMergeTreeandSharedSetrejected.pytest tests/unit/src/sqlbuild/adapters/clickhouse/test_table_layout.py: DDL withSharedMergeTreeandSharedReplacingMergeTree(version).make check-cipassed (clippy, fmt, ruff, ty, fensu, docs skill check).