Use theme-aware SVG favicon for Predbat web UI#3935
Open
jim-ip wants to merge 2 commits into
Open
Conversation
jim-ip
commented
May 17, 2026
Author
There was a problem hiding this comment.
Minor changes made to smooth out some of the vector curves where there were some indentations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Predbat currently uses
bat_logo_light.pngas the web favicon in both light mode and dark mode.On dark browser tab backgrounds this results in a dark icon on a dark background because the favicon does not adapt to the active colour scheme.
Changes
docs/images/bat_logo.svgas a theme-aware favicon assetapps/predbat/web_helper.pyto use the SVG favicon firstbat_logo_light.pngas a PNG fallbackCurrent behaviour
The HTML currently emits:
So both light mode and dark mode use the same light-mode PNG favicon.
Proposed behavior
The HTML will emit:
This allows supported browsers to use the theme-aware SVG favicon while preserving PNG fallback compatibility.