Support pepper in Password4j encoders#19102
Open
therepanic wants to merge 1 commit intospring-projects:mainfrom
Open
Support pepper in Password4j encoders#19102therepanic wants to merge 1 commit intospring-projects:mainfrom
therepanic wants to merge 1 commit intospring-projects:mainfrom
Conversation
Currently, we can't forward pepper unless we encounter an anti-pattern and implement our own encoder. To solve this problem, we need to provide pepper support out of the box, specifically in `Password4jPasswordEncoder` and all its subclasses, as well as `BalloonHashingPassword4jPasswordEncoder` and `Pbkdf2Password4jPasswordEncoder`, which aren't direct implementations of `Password4jPasswordEncoder` but also use `password4j` and require pepper support. Closes: spring-projectsgh-18299 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
therepanic
commented
Apr 18, 2026
Comment on lines
59
to
+71
| @@ -66,7 +68,20 @@ public BcryptPassword4jPasswordEncoder() { | |||
| * @throws IllegalArgumentException if bcryptFunction is null | |||
| */ | |||
| public BcryptPassword4jPasswordEncoder(BcryptFunction bcryptFunction) { | |||
| super(bcryptFunction); | |||
| this(bcryptFunction, null); | |||
Contributor
Author
There was a problem hiding this comment.
i guess this is ok?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we can't forward pepper unless we encounter an anti-pattern and implement our own encoder.
To solve this problem, we need to provide pepper support out of the box, specifically in
Password4jPasswordEncoderand all its subclasses, as well asBalloonHashingPassword4jPasswordEncoderandPbkdf2Password4jPasswordEncoder, which aren't direct implementations ofPassword4jPasswordEncoderbut also usepassword4jand require pepper support.Closes: gh-18299