GH-11235: Restore URL-encoded form conversion - #11236
Open
DragonFSKY wants to merge 1 commit into
Open
Conversation
Route URL-encoded form data through FormHttpMessageConverter while retaining multipart handling and MultipartFileReader support. Fixes: spring-projectsgh-11235 Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11235
Spring Framework 7.1 split URL-encoded form and multipart conversion into separate converters.
MultipartAwareFormHttpMessageConverterstill advertised support for URL-encoded forms, but delegated their reads to the multipart-only converter, causing requests without a multipart boundary to fail.This change routes URL-encoded data through
FormHttpMessageConverterwhile retaining the existing multipart handling andMultipartFileReadersupport. It also re-enables the proxy flow regression test using the publicMockMvcClientHttpRequestFactoryand adds focused converter coverage for read/write routing, charset, repeated values, and multipart behavior.Validation:
./gradlew :spring-integration-http:checkA full
./gradlew clean testwas also attempted. The HTTP module passed; the overall run encountered environment-dependent failures in unrelated IP tests and Redis, MQTT, and MySQL Testcontainers.