Skip to content

Polish collection usage in HttpHeadersTests#36760

Merged
bclozel merged 1 commit into
spring-projects:mainfrom
codingkiddo:polish-httpheaders-tests
May 11, 2026
Merged

Polish collection usage in HttpHeadersTests#36760
bclozel merged 1 commit into
spring-projects:mainfrom
codingkiddo:polish-httpheaders-tests

Conversation

@codingkiddo
Copy link
Copy Markdown
Contributor

This PR performs a small test-only readability cleanup in HttpHeadersTests.

Changes:

  • Replaces selected Arrays.asList(...) usages with List.of(...) where nulls and mutability are not required.
  • Simplifies small test collection setup where applicable.
  • Keeps production code unchanged.

No behavior change intended.

@codingkiddo codingkiddo force-pushed the polish-httpheaders-tests branch from a91f8c9 to 11525aa Compare May 7, 2026 05:41
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 7, 2026
@bclozel
Copy link
Copy Markdown
Member

bclozel commented May 7, 2026

@codingkiddo please run the build before submitting a pull request. You can do so with ./gradlew check locally. Once fixed, you can push additional commits to your branch to update this PR.
Also, please use a valid email when signing your commits. This doesn't need to be a public email, so an anonymized GitHub email works fine as long as GitHub associates it with your account. See https://spring.io/blog/2025/01/06/hello-dco-goodbye-cla-simplifying-contributions-to-spring/ for more

@codingkiddo codingkiddo force-pushed the polish-httpheaders-tests branch from 11525aa to 42f505e Compare May 7, 2026 09:13
@codingkiddo
Copy link
Copy Markdown
Contributor Author

codingkiddo commented May 7, 2026

Thanks for the guidance @bclozel.

I fixed the unused import reported by Checkstyle and updated the commit with the correct Signed-off-by email.

I ran the targeted checks successfully:

  • ./gradlew :spring-web:checkstyleTest
  • ./gradlew :spring-web:test --tests "org.springframework.http.HttpHeadersTests"
  • ./gradlew check

Signed-off-by: Vinod Kumar <codingkiddo@gmail.com>
@bclozel bclozel force-pushed the polish-httpheaders-tests branch from 42f505e to 238a24c Compare May 11, 2026 07:53
@bclozel bclozel added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 11, 2026
@bclozel bclozel added this to the 7.1.0-M1 milestone May 11, 2026
@bclozel bclozel merged commit 238a24c into spring-projects:main May 11, 2026
1 check passed
@bclozel
Copy link
Copy Markdown
Member

bclozel commented May 11, 2026

Thanks for your contribution @codingkiddo

@codingkiddo
Copy link
Copy Markdown
Contributor Author

Thank you for the review, guidance, and for merging this PR.

I really appreciate the opportunity to contribute to Spring Framework. This was a great learning experience around keeping changes focused, following project style, DCO/sign-off requirements, and validating changes properly.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants