Add support for Redis JSON - #3390
Open
Dgramada wants to merge 12 commits into
Open
Conversation
Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
Dgramada
marked this pull request as ready for review
June 30, 2026 11:43
Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
mp911de
reviewed
Jul 1, 2026
mp911de
left a comment
Member
There was a problem hiding this comment.
Here's an initial round of review feedback.
mp911de
reviewed
Jul 2, 2026
mp911de
reviewed
Jul 2, 2026
Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
9 tasks
Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
mp911de
force-pushed
the
main
branch
2 times, most recently
from
August 5, 2026 14:13
e0163c7 to
5e76bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up pull request to #3327 that handles the new JSON API for Spring Data Redis.
It builds upon the command layer from the referenced PR and adds API for the template layer.
Notes:
BoundJsonOperationsis not included yet. Once a version ofJsonOperationsis approved, the bound operations can be included in this branch.RedisJsonTemplateinitially felt like a good idea. It creates a separation of concerns, which is nice because the new JSON API does not pair well with a specificVtype unlike the other data types inRedisTemplate. However,RedisJsonTemplatefeels a little off and maybe a more elegant solution could be derived. It feels more like a configuration class. Maybe we could rename it toRedisJsonConfig. This would also promote developers to injectJsonOperationsdirectly.RedisJsonSerializerdoes not extendRedisSerializer, due to it bringing a lot of functionality that doesn't add any value to the JSON serialization. Furthermore, keeping them separate gives separation of concerns. Also Jedis and Lettuce do not provide byte[] APIs for the JSON commands in Redis, thus makingRedisSerializerincompatible.