fix: duplicated conditional TTL evaluation - #3267
Open
diydriller wants to merge 1 commit into
Open
Conversation
Signed-off-by: Hyun Jong Park <dhrhd080@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
LGTM |
christophstrobl
removed
the
status: waiting-for-triage
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
force-pushed
the
main
branch
2 times, most recently
from
August 5, 2026 14:13
e0163c7 to
5e76bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors duplicated TTL computation logic inside DefaultRedisCacheWriter's get method
following expression was previously evaluated twice
What Changed
A new local variable ttlForGet is introduced to compute the TTL once
Closes: #3266