GH-5388: Warn about mismatched JobRepository DataSource - #5437
Open
DragonFSKY wants to merge 1 commit into
Open
Conversation
DragonFSKY
force-pushed
the
fix/5388-datasource-transaction-manager
branch
from
August 25, 2026 13:57
57a7cf9 to
d973c9a
Compare
Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
DragonFSKY
force-pushed
the
fix/5388-datasource-transaction-manager
branch
from
August 26, 2026 02:04
d973c9a to
3f1f232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5388.
Add a warning during
JdbcJobRepositoryFactoryBeaninitialization when aResourceTransactionManagerexposes a differentDataSourcefrom the repository. The check is best-effort and reuses Spring's resource comparison; unsupported transaction managers are left unchanged. ATransactionAwareDataSourceProxyis compared using its target to avoid false warnings.One focused test verifies the mismatch warning, the valid proxy case, and unsupported transaction managers.
Tests:
./mvnw --no-transfer-progress -pl spring-batch-core -Dtest=JdbcJobRepositoryFactoryBeanTests test./mvnw --no-transfer-progress --quiet -pl spring-batch-core test(819 tests, 0 failures/errors)git diff --check