Only run unit-testing when there's something to test#4151
Merged
Conversation
Collaborator
|
I talked with @ljstella about this. Eventually we should handle this type of logic in the tool test workflow, but this is a good catch-all for now to ensure we don't waste time setting up environments when we won't actually have any content to test. I will defer to STRT for approval, but concur with the change. |
patel-bhavin
approved these changes
Jul 6, 2026
nasbench
reviewed
Jul 6, 2026
nasbench
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Tweak to the
unit-testingworkflow so that we only occupy the larger runner that testing uses when we actually have things to test, as opposed to every PR.This change is needed because the multi-step testing process w/ -ng now builds the test environment first, and then when running testing determines what needs to be tested, as opposed to determining if testing even needs to happen first.