Skip to content

Fix CI and README typos#116

Open
jessp01 wants to merge 8 commits into
spf13:mainfrom
jessp01:patch-1
Open

Fix CI and README typos#116
jessp01 wants to merge 8 commits into
spf13:mainfrom
jessp01:patch-1

Conversation

@jessp01

@jessp01 jessp01 commented Feb 24, 2025

Copy link
Copy Markdown
  • Fix gocritic findings:
    • Error: sloppyLen: len(goExecutable) <= 0 can be len(goExecutable) == 0 (gocritic)
    • Error: wrapperFunc: use bytes.ReplaceAll method in bytes.Replace(content, []byte("\r\n"), []byte("\n"), -1) (gocritic)
  • Update ENV matrix in accordance to what's used in the main cobra repo
  • Update .golangci.yml (taken from the main cobra repo).
  • Update actions/checkout, actions/setup-go@v5 and golangci/golangci-lint-action versions

@CLAassistant

CLAassistant commented Feb 24, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@marckhouzam marckhouzam left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marckhouzam

Copy link
Copy Markdown
Collaborator

I haven’t looked at the cobra-cli in a very long time. CI seems to be broken

@jessp01

jessp01 commented Feb 24, 2025

Copy link
Copy Markdown
Author

Hi @marckhouzam ,

I've aligned .github/workflows/test.yml with the matrix you use for the cobra repo. It should pass now.
If you'd like, I can also add a GoReleaser config, I think it can be useful for this repo.

@jessp01

jessp01 commented Feb 24, 2025

Copy link
Copy Markdown
Author

Now the tests themselves are failing. See https://github.com/jessp01/cobra-cli/actions/runs/13499877160/job/37715453667#step:6:75

`golangci/golangci-lint-action` versions
  Error: sloppyLen: len(goExecutable) <= 0 can be len(goExecutable) == 0 (gocritic)
  Error: wrapperFunc: use bytes.ReplaceAll method in `bytes.Replace(content, []byte("\r\n"), []byte("\n"), -1)` (gocritic)
@jessp01

jessp01 commented Feb 24, 2025

Copy link
Copy Markdown
Author

All CI issues are now fixed: https://github.com/jessp01/cobra-cli/actions/runs/13500614133

@jessp01 jessp01 changed the title Fix typos Fix CI and README typos Feb 24, 2025
@jessp01

jessp01 commented Feb 25, 2025

Copy link
Copy Markdown
Author

Hi @marckhouzam ,

Did you get a chance to review the CI fixes I applied? Don't mean to rush you, of course, just thought I'd tag you to make sure you're aware.

@jessp01

jessp01 commented May 1, 2025

Copy link
Copy Markdown
Author

Hi @marckhouzam ,

Just following up on this.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants