Skip to content

fix(ci): tolerate npm candidate tag cleanup failures #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pallyoung merged 1 commit into from
Aug 13, 2026
+19 −3
Merged

fix(ci): tolerate npm candidate tag cleanup failures #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,10 @@ jobs:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
PACKAGE_NAME: ${{ steps.release.outputs.package_name }}
ACCEPTANCE_DIST_TAG: ${{ steps.release.outputs.acceptance_tag }}
run: npm dist-tag rm "${PACKAGE_NAME}" "${ACCEPTANCE_DIST_TAG}"
run: |
if ! npm dist-tag rm "${PACKAGE_NAME}" "${ACCEPTANCE_DIST_TAG}"; then
echo "::warning title=Temporary npm dist-tag cleanup failed::${ACCEPTANCE_DIST_TAG} remains on ${PACKAGE_NAME}; npm rejected deletion. Candidate acceptance remains valid."
fi

- name: Download required Desktop acceptance report
if: inputs.promote && inputs.npm_tag == 'latest'
Expand Down Expand Up @@ -252,7 +255,9 @@ jobs:
FINAL_DIST_TAG: ${{ inputs.npm_tag }}
run: |
npm dist-tag add "${PACKAGE_NAME}@${CANDIDATE_VERSION}" "${FINAL_DIST_TAG}"
npm dist-tag rm "${PACKAGE_NAME}" "${ACCEPTANCE_DIST_TAG}"
if ! npm dist-tag rm "${PACKAGE_NAME}" "${ACCEPTANCE_DIST_TAG}"; then
echo "::warning title=Temporary npm dist-tag cleanup failed::${ACCEPTANCE_DIST_TAG} remains on ${PACKAGE_NAME}; npm rejected deletion. The ${FINAL_DIST_TAG} promotion remains valid."
fi

- name: Create and push release tag
if: inputs.promote
Expand Down
13 changes: 12 additions & 1 deletion scripts/github-workflows.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,9 @@ describe("GitHub workflow boundaries", () => {
const acceptanceIndex = steps.findIndex(
(step) => step.name === "Run isolated packaged CLI acceptance"
);
const candidateCleanupIndex = steps.findIndex(
(step) => step.name === "Remove candidate-only npm dist-tag"
);
const desktopReportIndex = steps.findIndex(
(step) => step.name === "Validate required Desktop acceptance report"
);
Expand All @@ -552,6 +555,7 @@ describe("GitHub workflow boundaries", () => {
expect(validatePackageIndex).toBeGreaterThan(packIndex);
expect(stageIndex).toBeGreaterThan(validatePackageIndex);
expect(acceptanceIndex).toBeGreaterThan(stageIndex);
expect(candidateCleanupIndex).toBeGreaterThan(acceptanceIndex);
expect(desktopReportIndex).toBeGreaterThan(acceptanceIndex);
expect(preserveDesktopIndex).toBeGreaterThan(desktopReportIndex);
expect(promoteIndex).toBeGreaterThan(preserveDesktopIndex);
Expand All @@ -569,12 +573,19 @@ describe("GitHub workflow boundaries", () => {
expect(steps[stageIndex]?.run).toContain('pnpm publish "${tarball}"');
expect(steps[stageIndex]?.run).not.toMatch(/(^|\s)npm publish "\$\{tarball\}"/);
expect(steps[acceptanceIndex]?.run).toContain("pnpm acceptance:cli:update");
expect(steps[candidateCleanupIndex]?.if).toBe("inputs.promote == false");
expect(steps[candidateCleanupIndex]?.run).toContain("if ! npm dist-tag rm");
expect(steps[candidateCleanupIndex]?.run).toContain("::warning");
expect(steps[desktopReportIndex]?.run).toContain("wsl-combined");
expect(steps[desktopReportIndex]?.run).toContain("fresh-native");
expect(steps[desktopReportIndex]?.run).toContain("fresh-wsl");
expect(steps[preserveDesktopIndex]?.if).toBe("inputs.promote");
expect(steps[promoteIndex]?.run).toContain("npm dist-tag add");
expect(steps[promoteIndex]?.run).toContain("npm dist-tag rm");
expect(steps[promoteIndex]?.run).toContain("if ! npm dist-tag rm");
expect(steps[promoteIndex]?.run).toContain("::warning");
expect(steps[promoteIndex]?.run?.indexOf("npm dist-tag add")).toBeLessThan(
steps[promoteIndex]?.run?.indexOf("if ! npm dist-tag rm") ?? -1
);
expect(preserveDesktop?.run).toContain(
'gh release download "${latest_tag}" --dir desktop-channel-assets --clobber'
);
Expand Down
Loading