Verify: Returns 1 for invalid SPDX doc; 2 for bad args#300
Merged
Conversation
run() returns an exit-status int instead of calling System.exit() directly. No behavior change. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
USAGE_ERROR_STATUS=2 for bad invocation (missing args, invalid file type, invalid file name); ERROR_STATUS=1 stays for invalid or unreadable SPDX documents. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
bact
marked this pull request as draft
July 16, 2026 13:22
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
bact
marked this pull request as ready for review
July 16, 2026 14:08
This was referenced Jul 16, 2026
goneall
requested changes
Jul 19, 2026
goneall
left a comment
goneall
left a comment
Member
There was a problem hiding this comment.
Just one change requested - I don't think we need to deprecate the unused constant, we can just delete it.
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement exit codes as proposed in #299
Remove unused
ERROR_STATUS.