fix: raise MSIX minimum Windows version for Store submission#52
Merged
Conversation
- Fix MSIX manifest patching: replaced regex -creplace with proper XML DOM to avoid corrupting MinVersion and MaxVersionTested attributes - Root cause: 'Version="[^"]+"' regex matched inside MinVersion and MaxVersionTested, overwriting them with the app version number - v1.2.1 generated MSIX had MinVersion="1.2.1.0" instead of 10.0.17763.0 - Fixed in: release.yml, build-windows.yml, build-msix.ps1 - Added CI validation logging for MinVersion and MaxVersionTested - Added MinVersion check to store submission checklist - Version bumped to 1.2.2 (MSIX 1.2.2.0) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: MSIX Manifest Patching Bug — Partner Center Rejection
Root Cause
The CI workflow used regex
-creplace 'Version="[^"]+"'to patch the app version intoAppxManifest.xml. This regex matched insideMinVersionandMaxVersionTestedattributes because they contain the substringVersion=.Generated MSIX for v1.2.1 had:
Partner Center rejects packages with
MinVersion <= 10.0.17134.0. Since1.2.1.0 < 10.0.17134.0, the upload was rejected.Fix
Replaced all regex-based version patching with proper XML DOM manipulation in:
release.yml(CI release build)build-windows.yml(CI dev build)build-msix.ps1(local build script)Added CI validation logging for
MinVersionandMaxVersionTested.Source Manifest (unchanged, already correct)
Version Bump
1.2.21.2.2.0Files Changed
12 files, +64/-37