Skip to content

fix: file storage module should abort file download on request cancellation - #1712

Open
Roshan931 wants to merge 1 commit into
spacecloud-io:masterfrom
Roshan931:prilog/fix-error-s3-file-download-ignores-request-context-08-21-2026-7c2a63
Open

fix: file storage module should abort file download on request cancellation#1712
Roshan931 wants to merge 1 commit into
spacecloud-io:masterfrom
Roshan931:prilog/fix-error-s3-file-download-ignores-request-context-08-21-2026-7c2a63

Conversation

@Roshan931

Copy link
Copy Markdown

Fixes #1248

Root cause

S3 file download ignores request context cancellation

Changes

  • Use s3manager Downloader.DownloadWithContext with the request-scoped context in AmazonS3.ReadFile so the download aborts when the HTTP request is cancelled; the existing error path already closes and removes the temp file.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

file storage module should abort file download on request cancellation

2 participants