Conversation
Port Finder automation, VS Code launching, and path handling to Swift 6. Rewrite the focused tests and remove the generated Finder Objective-C bridge and legacy build settings. Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
There was a problem hiding this comment.
Pull request overview
Migrates the macOS Finder utility from Objective-C to Swift 6 while preserving existing path resolution and VS Code launch behavior.
Changes:
- Reimplements Finder automation and application launch flow in Swift.
- Ports core path logic and tests to Swift 6.
- Updates build configuration, test tooling, and contributor guidance.
Show a summary per file
| File | Description |
|---|---|
main.swift |
Adds the Swift application entry point and Finder automation. |
main.m |
Removes the Objective-C entry point. |
OpenInCodeCore.swift |
Ports shared path and editor-priority logic to Swift. |
OpenInCodeCore.h |
Removes the obsolete Objective-C interface. |
OpenInCodeCore.m |
Removes the Objective-C core implementation. |
Tests/OpenInCodeCoreTests.swift |
Ports focused core tests to Swift. |
Tests/OpenInCodeCoreTests.m |
Removes the Objective-C tests. |
scripts/test.sh |
Compiles and runs the Swift 6 tests. |
Open in Code.xcodeproj/project.pbxproj |
Configures Swift sources and removes ScriptingBridge generation. |
Open in Code_Prefix.pch |
Removes the obsolete Objective-C prefix header. |
AGENTS.md |
Updates repository guidance for Swift development. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 11/11 changed files
- Comments generated: 0
- Review effort level: Medium
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 733dfb3d33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Replace the Xcode project with a SwiftPM executable and XCTest target. Add a universal app packaging script for Icon Composer assets, bundle metadata, signing, and release workflow integration. Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan
changed the title
Resolve Finder file-reference URLs before path extraction, bridge NSWorkspace launching through async/await, and document every accepted packaging signing mode. Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
|
@codex review |
Run focused tests and assemble a signed universal app for pull requests and master pushes. Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e1a9311bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
lipo, compiles the Icon Composer asset withactool, assembles the app bundle, and supports unsigned or ad-hoc signingValidation
./scripts/test.shOPEN_IN_CODE_SIGNING=unsigned ./scripts/build-app.sh releaseARCHES="arm64 x86_64" OPEN_IN_CODE_SIGNING=unsigned ./scripts/build-app.sh releasecodesign; Finder automation entitlement confirmedshellcheck,actionlint,bash -n,plutil -lint, andswift package dump-package