fix(build): configure macOS SDK signing#21
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
There was a problem hiding this comment.
Pull request overview
Configures SDK-scoped signing for macOS Release builds and normalizes Xcode project ordering.
Changes:
- Adds macOS-specific signing identity and development team.
- Reorders the
OpenInCodeCore.mbuild-file entry.
Show a summary per file
| File | Description |
|---|---|
Open in Code.xcodeproj/project.pbxproj |
Updates Release signing and project entry ordering. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
| "CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development"; | ||
| CODE_SIGN_STYLE = Manual; | ||
| COMBINE_HIDPI_IMAGES = YES; | ||
| DEVELOPMENT_TEAM = VURRGRYW45; | ||
| "DEVELOPMENT_TEAM[sdk=macosx*]" = 57QNR9B89Q; |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24c6c240cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development"; | ||
| CODE_SIGN_STYLE = Manual; | ||
| COMBINE_HIDPI_IMAGES = YES; | ||
| DEVELOPMENT_TEAM = VURRGRYW45; | ||
| "DEVELOPMENT_TEAM[sdk=macosx*]" = 57QNR9B89Q; |
There was a problem hiding this comment.
Keep Release signing on Developer ID
For normal macOS Release builds/archives, the sdk=macosx* conditional applies and overrides the unqualified Release CODE_SIGN_IDENTITY/DEVELOPMENT_TEAM, so Xcode will select Apple Development with team 57QNR9B89Q instead of the configured Developer ID identity/team. That conflicts with the documented Release path in README.md lines 27 and 37, and with the release workflow's own distinction that Apple Development builds are not notarized (.github/workflows/release.yml lines 165-170), so Release archives produced from the project become unsuitable for public distribution even when a Developer ID certificate is installed.
Useful? React with 👍 / 👎.
Summary
OpenInCodeCore.mbuild-file entry ordering generated by XcodeWhy
The project needs explicit SDK-scoped signing values so Xcode resolves the intended Apple Development identity and team for macOS builds instead of relying only on the generic Release signing configuration.
Impact
Release builds targeting the macOS SDK now resolve
Apple Developmentwith team57QNR9B89Q. No application source code or runtime behavior changes.Validation
plutil -lint 'Open in Code.xcodeproj/project.pbxproj'xcodebuild -list -project 'Open in Code.xcodeproj'./scripts/test.shCODE_SIGNING_ALLOWED=NO