fix: modernize macOS integration#20
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df27945c22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Pull request overview
Modernizes Finder integration, path resolution, launching, signing, and project portability.
Changes:
- Adds robust Finder/VS Code handling with visible errors.
- Modernizes build, signing, privacy, icon, and deployment settings.
- Adds focused regression tests and updated documentation.
Show a summary per file
| File | Description |
|---|---|
.gitignore |
Ignores Finder metadata. |
Info.plist |
Updates privacy, version, icon, and OS metadata. |
Open in Code.entitlements |
Enables Finder automation events. |
Open in Code.xcodeproj/project.pbxproj |
Modernizes build and signing configuration. |
Open in Code.xcodeproj/project.xcworkspace/contents.xcworkspacedata |
Removes machine-specific workspace path. |
OpenInCodeCore.h |
Declares path and editor helpers. |
OpenInCodeCore.m |
Implements editor preference and path resolution. |
main.m |
Adds resilient Finder access and modern launching. |
README.md |
Replaces installation and development guidance. |
scripts/test.sh |
Adds the focused test runner. |
Tests/OpenInCodeCoreTests.m |
Covers path and editor-selection behavior. |
vscode.icon/icon.json |
Defines the Icon Composer asset. |
vscode.icon/Assets/vscode-alt.png |
Supplies the icon artwork. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Files not reviewed (1)
- Open in Code.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Generated file
- Files reviewed: 10/14 changed files
- Comments generated: 3
- Review effort level: Medium
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c751b2d60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21d8e16b04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 406cdd6e5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8902a7ab06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
NSWorkspaceOpenConfigurationsozercan/homebrew-repowith a generated caskWhy
The existing project could not build with the current Xcode toolchain, lacked the Apple Events declaration required for its core Finder integration, silently produced unsigned release artifacts, and contained machine-specific Xcode paths. Several runtime edge cases could also crash, open the wrong folder, or silently do nothing.
User impact
Finder locations now open reliably in the expected VS Code channel. Permission and launch failures display actionable messages instead of crashing or failing invisibly. The project can be cloned and built from another path, and release configuration no longer silently emits an unsigned distributable.
Validation
./scripts/test.shCODE_SIGNING_ALLOWED=NOarm64/x86_64archive using an ad-hoc validation overridecodesign --verify --deep --stricton the validation archivegpt-5.6-solmax reviews for runtime and project configuration changeshomebrew-repocloneRelease signing note
The Release configuration intentionally requires a Developer ID Application certificate for team
VURRGRYW45. A notarized public artifact was not produced because that private signing credential is not installed in the review environment.